Setting job retries to unlimited(--job-retries=0) stops after 256 attempts
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Gearman |
Fix Committed
|
Low
|
Brian Aker |
Bug Description
In the function gearman_
I fount this issue in versions 0.33, and it looks like it is present in all versions up to the latest. I have attached a patch to fix this issue.
Also, what was the point of limiting the retry count to a uint8? Setting job-retries to something larger than 255 also triggers the same problem, although that seems to be because the code is casting a uint32 that it reads from the command line options into a uint8 inside main() in gearmand/
Changed in gearmand: | |
assignee: | nobody → Brian Aker (brianaker) |
importance: | Undecided → Low |
status: | New → In Progress |
milestone: | none → 1.0.3 |
Changed in gearmand: | |
status: | In Progress → Fix Committed |
Thanks for the quick fix, however you missed one change. The value is still being cast to a uint8 when being passed to the gearmand_create() function on line 350 in gearmand/ gearmand. cc.