no error displayed on failed fingerprint authentication

[Alex Tu]

[ Impact ]

No fingerprint errors are exposed on fingerprint login failures.

from journalctl, gdm-fingerprint shows error there after retried 5 times of fingerprint login failed, so I open this issue here.

[ Test case ]

1. enroll fingerprint for your right index finger.
2. logout
3. login and try login by incorrect finger e.g. middle finger
4. Each time the wrong finger is used an error is shown
5. After 3 times retries, an authentication error is shown, suggesting
   to use another method.

[ Regression potential]

Wrong errors are shown during both fingerprint auth and other kinds of authentications.
Password failures aren't properly exposed. Verification can't restart on error.

Password authentication doesn't work anymore for users with no enrolled prints (as per LP: #1915570)

---

ProblemType: BugDistroRelease: Ubuntu 20.04
Package: gdm3 3.34.1-1ubuntu1
ProcVersionSignature: Ubuntu 5.4.0-14.17-generic 5.4.18
Uname: Linux 5.4.0-14-generic x86_64
ApportVersion: 2.20.11-0ubuntu18
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Tue Mar 3 15:32:00 2020
InstallationDate: Installed on 2020-03-02 (0 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Alpha amd64 (20200301)SourcePackage: gdm3
UpgradeStatus: No upgrade log present (probably fresh install)

[Alex Tu (alextu)]

the message in journalctl shows that fprintd and gdm-fingerprint know user is trying on incorrect finger.

https://paste.ubuntu.com/p/QkySMYzVmC/

[Sebastien Bacher (seb128)]

Thanks Alex, you assigned the bug to yourself, does it mean you are working on fixing the issue?

I've sent it upstream as well now
https://gitlab.gnome.org/GNOME/gdm/issues/567

[Alex Tu (alextu)]

sorry, I wanted to track the progress by "OEM Priority Project" and assigned myself in the wrong series.

[Alex Tu (alextu)]

This issue can also be reproduced on Lenovo X240 which is using open source FPT driver [1] for FP device 138a:0017 Validity VFS5011.

[1] https://fprint.freedesktop.org/supported-devices.html

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.38.3-2ubuntu1

---------------
gnome-shell (3.38.3-2ubuntu1) hirsute; urgency=medium

  * Merge with debian, containing new upstream release (LP: #1915089)
  * debian/patches: Correctly handle login cancellation and failures.
    Ensure the GDM workers are terminated before restarting a new auth
    request, allowing fingerprint authentication to be restarted.
    (LP: #1915066)
  * debian/patches: Show errors on fingerprint failures and limit retries.
    (LP: #1865838)
  * debian/control: BD on gstreamer and pipewire, depend on gstreamer1.0-pipewire.
    Enable building with pipewire now that is in main and add runtime
    dependency on gstreamer-pipewire to gnome-shell (LP: #1901391).

gnome-shell (3.38.3-2) unstable; urgency=medium

  * Team upload
  * d/patches: Update to 3.38.3-3-ge3dc4401d from gnome-3-38 branch
    - Fix opening Extensions app from notification
    - Fix workspace layout in right-to-left locales
    - Don't break window focusing if trying to take an area screenshot while
      an application such as a game has an X11 grab (LP: #1910235)

gnome-shell (3.38.3-1) unstable; urgency=medium

  * Team upload
  * d/watch: Only watch for 3.38.x versions
  * New upstream release

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 09 Feb 2021 05:16:10 +0100

[Brian Murray (brian-murray)]

Hello Alex, or anyone else affected,

Accepted gnome-shell into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.38.3-2ubuntu0.20.10.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Andy Chi (andch)]

Test on XPS 9310 with 5.8.0-48-generic kernel, BIOS: 1.2.5 with, codename: groovy.

Login page will pop up message to notify user, if user uses finger which is not registered.

[Timo Aaltonen (tjaalton)]

Hello Alex, or anyone else affected,

Accepted gnome-shell into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-shell/3.36.9-0ubuntu0.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted gnome-shell (3.36.9-0ubuntu0.20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:20.04.10.6 (ppc64el, amd64, armhf, s390x, arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#gnome-shell

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Andy Chi (andch)]

Test on XPS 9310 with 5.10.0-1025-oem kernel, BIOS: 2.2.0 with, codename: focal.

Login page will pop up message to notify user, if user uses finger which is not registered.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.36.9-0ubuntu0.20.04.1

---------------
gnome-shell (3.36.9-0ubuntu0.20.04.1) focal; urgency=medium

  * New upstream release (LP: #1921963):
    - Improve login screen accessibility
    - Prefer image-data hint over app-icon in notifications
    - Plugged leak
    - Fixed crashes
  * debian/patches:
    - Correctly handle login cancellation and failures (LP: #1915066)
    - Show errors on fingerprint failures and limit retries (LP: #1865838)
    - gdm: Don't try to retry authenticating when the service is unavailable
      (LP: #1915570)
    - Enable to use Escape to cancel auth requests (with limits) (LP: #1921929)

 -- Marco Trevisan (Treviño) <email address hidden> Wed, 31 Mar 2021 00:50:16 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-shell has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-shell - 3.38.3-2ubuntu0.20.10.2

---------------
gnome-shell (3.38.3-2ubuntu0.20.10.2) groovy; urgency=medium

  * d/p/gdm-Don-t-try-to-retry-authenticating-when-the-service-is.patch:
    - gdm: Don't try to retry authenticating when the service is unavailable
      (Related to lp:1915570, regression in 3.38.3-2ubuntu0.20.10.1)

gnome-shell (3.38.3-2ubuntu0.20.10.1) groovy; urgency=medium

  * Merge with debian, containing new upstream release (LP: #1915089)
  * debian/patches: Correctly handle login cancellation and failures.
    Ensure the GDM workers are terminated before restarting a new auth
    request, allowing fingerprint authentication to be restarted.
    (LP: #1915066)
  * debian/patches: Show errors on fingerprint failures and limit retries.
    (LP: #1865838)

gnome-shell (3.38.3-2) unstable; urgency=medium

  * Team upload
  * d/patches: Update to 3.38.3-3-ge3dc4401d from gnome-3-38 branch
    - Fix opening Extensions app from notification
    - Fix workspace layout in right-to-left locales
    - Don't break window focusing if trying to take an area screenshot while
      an application such as a game has an X11 grab (LP: #1910235)

gnome-shell (3.38.3-1) unstable; urgency=medium

  * Team upload
  * d/watch: Only watch for 3.38.x versions
  * New upstream release

 -- Marco Trevisan (Treviño) <email address hidden> Tue, 16 Feb 2021 05:23:21 +0100

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Sebastien Bacher (seb128)]

the issue was fixed by the shell update so the other components can be closed right?

[Andy Chi (andch)]

@seb128,
Yes, it is fixed by shell update, please close other component. Thanks