Status text should be selectable

[Karderio]

It would be handy if you could select the status text. This would allow you to copy the text, into a web browser for example.

I had a dependency with a long package name, which I wanted to search for, but which I had to retype.

The GNOME HIG recommends selectable text for dialogs.

http://developer.gnome.org/projects/gup/hig/2.0/windows-alert.html#alert-text

Love, Karderio

[Karderio (karderio)]

Here is a quick patch that seems to work. I generated this patch with "bzr diff". This is the first time I have used bzr, so I'm not sure if this is a valid patch. To be honest I spent ages just checking the source code out, bazaar seems to have much potential all the same ;)

Patch follows.

Love, Karderio.

-------------------------------------------------

=== modified file 'data/gdebi.glade'
--- data/gdebi.glade
+++ data/gdebi.glade
@@ -147,12 +147,13 @@
              <child>
                <widget class="GtkLabel" id="label_name">
                  <property name="visible">True</property>
+ <property name="can_focus">True</property>
                  <property name="label" translatable="yes">&lt;b&gt;&lt;big&gt; &lt;/big&gt;&lt;/b&gt;</property>
                  <property name="use_underline">False</property>
                  <property name="use_markup">True</property>
                  <property name="justify">GTK_JUSTIFY_LEFT</property>
                  <property name="wrap">False</property>
- <property name="selectable">False</property>
+ <property name="selectable">True</property>
                  <property name="xalign">0</property>
                  <property name="yalign">0.5</property>
                  <property name="xpad">0</property>
@@ -181,12 +182,13 @@
                  <child>
                    <widget class="GtkLabel" id="label_status">
                      <property name="visible">True</property>
+ <property name="can_focus">True</property>
                      <property name="label" translatable="yes"> </property>
                      <property name="use_underline">False</property>
                      <property name="use_markup">False</property>
                      <property name="justify">GTK_JUSTIFY_LEFT</property>
                      <property name="wrap">True</property>
- <property name="selectable">False</property>
+ <property name="selectable">True</property>
                      <property name="xalign">0</property>
                      <property name="yalign">0.5</property>
                      <property name="xpad">0</property>
@@ -285,12 +287,13 @@

              <child>
                <widget class="GtkLabel" id="label_desc">
+ <property name="can_focus">True</property>
                  <property name="label" translatable="yes"></property>
                  <property name="use_underline">False</property>
                  <property name="use_markup">False</property>
                  <property name="justify">GTK_JUSTIFY_LEFT</property>
                  <property name="wrap">False</property>
- <property name="selectable">False</property>
+ <property name="selectable">True</property>
                  <property name="xalign">0</property>
                  <property name="yalign">0.5</property>
                  <property name="xpad">0</property>

[Karderio (karderio)]

ping

[Michael Vogt (mvo)]

There is currently a bug in either the ubntu human theme or somewhere else in gtk that makes selectable entries selected by default too. This means that on startup the first selectable label is hightlighted. Once this is resolved, we can enable this feature.

Cheers,
 Michael

[Launchpad Janitor (janitor)]

This bug was fixed in the package gdebi - 0.4.0

---------------
gdebi (0.4.0) jaunty; urgency=low

  [ Michael Vogt ]
  * i18n fixes (LP: #313890), thanks to Gabor Kelemen
  * merged da.po translation update (thanks to Joe Dalton)
  * GDebi/DebPackage.py:
    - better error string for versionized dependencies (LP: #160218)
    - do not crash on packages with no architecture field but show
      a error instead (LP: #261266)
    - fix improper checking for reverse conflicts/strict dependencies
      (LP: #312022)
  * GDebi/GDebi.py:
    - fix filelist display for debs with utf-8 chars (LP: #257597)
    - add refresh action (LP: #156214)
    - tell the user what is being installed
  * data/gdebi.glade:
    - make the status text selectable (LP: #50212)
    - Open is now "Open..." (LP:# 90010)
  * unify the utf8 methods and deal properly with non-utf8 input
    (fixes crash in gdebi-kde, LP: #149893)

  [ Harald Sitter ]
  * Fix gdebi-kde icon (application-x-deb)
  * Change install path of gdebi-kde desktop file to applications/kde4

 -- Michael Vogt <email address hidden> Fri, 23 Jan 2009 08:39:52 +0100