4.7: ICE in reload_cse_simplify_operands, at postreload.c:403 with -O1 -march=armv7-a -mthumb

[Bernhard Rosenkraenzer]

New issue in current bzr builds -- the 12.08 release is fine:

cts/apps/CtsVerifier/lib/colorchecker/colorcheckertest.cpp:425:1: error: insn does not satisfy its constraints:
(insn 5241 5240 147 2 (set (zero_extract:SI (reg/f:SI 13 sp)
            (const_int 16 [0x10])
            (const_int 16 [0x10]))
        (const_int 65535 [0xffff])) cts/apps/CtsVerifier/lib/colorchecker/colorcheckertest.cpp:256 348 {*arm_movtas_ze}
     (nil))
cts/apps/CtsVerifier/lib/colorchecker/colorcheckertest.cpp:425:1: internal compiler error: in reload_cse_simplify_operands, at postreload.c:403

[Bernhard Rosenkraenzer (berolinux)]

Attaching reduced test case:

[bero@localhost grouper-4.1.1]$ /opt/android-toolchain-4.7/bin/arm-linux-androideabi-g++ -O1 -mthumb -march=armv7-a -c bug1046999.cc -o bug1046999.o
bug1046999.cc: In function 'void bug1046999()':
bug1046999.cc:12:1: error: insn does not satisfy its constraints:
(insn 121 120 52 2 (set (zero_extract:SI (reg/f:SI 13 sp)
            (const_int 16 [0x10])
            (const_int 16 [0x10]))
        (const_int 65535 [0xffff])) bug1046999.cc:3 348 {*arm_movtas_ze}
     (nil))
bug1046999.cc:12:1: internal compiler error: in reload_cse_simplify_operands, at postreload.c:403
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

[Michael Hope (michaelh1)]

Thank you for the bug report. I've confirmed this with gcc-linaro-4.7+bzr115016.

michaelh@crucis:~/linaro/bugs$ ~/linaro/gcc/build/4.7/install/bin/arm-linux-gnueabi-g++ -O1 -S bug1046999.cc
bug1046999.cc: In function ‘void bug1046999()’:
bug1046999.cc:12:1: error: insn does not satisfy its constraints:
(insn 117 116 48 2 (set (zero_extract:SI (reg/f:SI 13 sp)
            (const_int 16 [0x10])
            (const_int 16 [0x10]))
        (const_int 65535 [0xffff])) bug1046999.cc:3 348 {*arm_movtas_ze}
     (nil))
bug1046999.cc:12:1: internal compiler error: in reload_cse_simplify_operands, at postreload.c:403

The fault is introduced by bzr115014 and is caused by the new add pattern not handling a sp = rx + constant pattern, causing reload to turn this into a movw, movt, and add. The pattern above is the movt part.

The fault exists upstream as at svn191044. Could you report it in GCC bugzilla and record it against this ticket?

I've set this to high priority as it's an ICE with no work around.

[Michael Hope (michaelh1)]

Oh, and the fault was introduced in svn190472 by rearnshaw.

[Michael Hope (michaelh1)]

It seems that the r/r/k patterns used for other forms also need doing for the add. A shortcut is to remove the k constraint from the first operand, forcing sp adds to use a later alternative.

[Bernhard Rosenkraenzer (berolinux)]

Created attachment 28143
Reduced test case

$ arm-linux-gnueabi-g++ -O1 -march=armv7-a -mthumb -S ice.cc
ice.cc: In function 'void bug1046999()':
ice.cc:12:1: error: insn does not satisfy its constraints:
(insn 121 120 52 2 (set (zero_extract:SI (reg/f:SI 13 sp)
            (const_int 16 [0x10])
            (const_int 16 [0x10]))
        (const_int 65535 [0xffff])) bug1046999.cc:3 348 {*arm_movtas_ze}
     (nil))
ice.cc:12:1: internal compiler error: in reload_cse_simplify_operands, at postreload.c:403
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.

Introduced in svn rev 190472

[Bernhard Rosenkraenzer (berolinux)]

Upstream bug report http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54516

[Rearnsha (rearnsha)]

Confirmed.

[Rearnsha (rearnsha)]

Nothing to do with gcc-4.7

[Michael Hope (michaelh1)]

Marked as affecting. Will bring up at todays meeting. Revert underway.

[Michael Hope (michaelh1)]

Reverted.

[Rearnsha (rearnsha)]

Author: rearnsha
Date: Fri Sep 14 17:10:45 2012
New Revision: 191307

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=191307
Log:
 PR target/54516
 PR rtl-optimization/54540
 * reload.c (find_dummy_reload): Don't use OUT as a reload reg
 for IN if it overlaps a fixed register.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/reload.c

[Rearnsha (rearnsha)]

Fixed