multiple autopilot test failures in trunk
Bug #1422418 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| gallery-app |
Fix Released
|
Critical
|
Olivier Tilloy | ||
Bug Description
A recent change in lp:gallery-app (the fix for bug #1416043 at revision 1143) changed the way images are selected. It seems the autopilot tests were not updated to account for the change, resulting in multiple test failures.
Related branches
lp:~osomon/gallery-app/photos-selection-ap-tests
- Ugo Riboni (community): Approve
-
Diff: 454 lines (+71/-60)15 files modifiedrc/qml/AlbumEditor/AlbumCoverMenu.qml (+2/-2)
rc/qml/MainScreen.qml (+7/-4)
rc/qml/MediaViewer/MediaViewer.qml (+2/-2)
rc/qml/OrganicView/OrganicItemInteraction.qml (+1/-0)
tests/autopilot/gallery_app/emulators/album_editor.py (+3/-3)
tests/autopilot/gallery_app/emulators/album_view.py (+8/-8)
tests/autopilot/gallery_app/emulators/gallery_utils.py (+5/-6)
tests/autopilot/gallery_app/emulators/photo_viewer.py (+5/-4)
tests/autopilot/gallery_app/emulators/picker_screen.py (+4/-9)
tests/autopilot/gallery_app/tests/test_album_editor.py (+8/-6)
tests/autopilot/gallery_app/tests/test_album_view.py (+6/-4)
tests/autopilot/gallery_app/tests/test_albums_view.py (+5/-4)
tests/autopilot/gallery_app/tests/test_photo_viewer.py (+3/-2)
tests/autopilot/gallery_app/tests/test_photos_view.py (+8/-3)
tests/autopilot/gallery_app/tests/test_picker_mode.py (+4/-3)
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #2 |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #3 |
| Changed in gallery-app: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
There are mostly two classes of failures there:
- Selecting a picture in selection mode requires tapping the checkbox in its upper-right corner now, whereas tapping the picture itself used to be sufficient (quite easy to fix).
- Revision 1143 introduced a number of dynamic changes of fullscreen mode (which imho are questionable in terms of UX), and it seems that when computing the coordinates of a menu item on screen, autopilot gets confused if the indicators bar is absent (i.e. in fullscreen mode). Not sure how to fix that one yet.