[gallery] [dialog] delete photo dialog should only have 1 primary (orange) button

Bug #1207399 reported by Christina Li
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Invalid
Undecided
Unassigned
Ubuntu UX
Fix Released
Medium
Calum Pringle
gallery-app
Fix Released
Medium
Omer Akram
gallery-app (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Current:
When deleting a photo in Gallery, a dialog is displayed with 'Yes' or 'No' options. Both options are currently orange.

Desired behaviour:
Only the affirmative option should be in orange, the cancel option should be in grey.
See guidelines:
http://design.ubuntu.com/apps/building-blocks/dialog

Related branches

John Lea (johnlea)
Changed in ubuntu-ux:
assignee: nobody → Calum Pringle (calumpringle)
Revision history for this message
Tim Peeters (tpeeters) wrote :

not a bug in ubuntu-ui-toolkit, this is already possible like this:

        Component {
            id: dialog
            Dialog {
                id: dialogue

                title: "Sample Dialog"
                text: "Are you sure you want to delete this file?"

                Button {
                    text: "Cancel"
                    gradient: UbuntuColors.greyGradient
                    onClicked: PopupUtils.close(dialogue)
                }
                Button {
                    text: "Delete"
                    onClicked: PopupUtils.close(dialogue)
                }
            }
        }

Changed in ubuntu-ui-toolkit:
status: New → Invalid
Changed in ubuntu-ux:
status: New → Fix Committed
importance: Undecided → Medium
Omer Akram (om26er)
Changed in gallery-app (Ubuntu):
importance: Undecided → Medium
Changed in gallery-app:
importance: Undecided → Medium
assignee: nobody → Omer Akram (om26er)
status: New → In Progress
Changed in gallery-app (Ubuntu):
status: New → In Progress
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:gallery-app at revision None, scheduled for release in gallery-app, milestone ubuntu-13.04-month-5

Changed in gallery-app:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gallery-app - 0.0.67+14.04.20131217-0ubuntu1

---------------
gallery-app (0.0.67+14.04.20131217-0ubuntu1) trusty; urgency=low

  [ Omer Akram ]
  * Changes the color of the delete dialog's cancel button. (LP:
    #1207399)

  [ Dmitrijs Ledkovs ]
  * Remove gstreamer0.10-ffmpeg dependency. (LP: #1254033). (LP:
    #1254033)

  [ Olivier Tilloy ]
  * Use QT5_WRAP_CPP instead of QT_WRAP_CPP. Fixes building from source
    on an up-to-date trusty setup. (LP: #1261417)
  * Fix a flaky test by always waiting for the confirmation dialogue to
    be fully visible before interacting with it.

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 892
 -- Ubuntu daily release <email address hidden> Tue, 17 Dec 2013 18:52:44 +0000

Changed in gallery-app (Ubuntu):
status: In Progress → Fix Released
Changed in gallery-app:
status: Fix Committed → Fix Released
John Lea (johnlea)
Changed in ubuntu-ux:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.