replicator.causal_read_timeout value is not parsed from configuration

Bug #1070370 reported by Ovidiu G.
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Galera
Fix Released
Undecided
Alex Yurchenko

Bug Description

Bug description:

The replicator.causal_read_timeout value defined in the wsrep_provider_options in the mysql configuration file (my.cnf / wsrep.conf) is not being parsed on initialization and the ReplicatorSMM::causal_read function will always use the default value of "PT30S".

Steps I used to check:

- modify and build libgalera_smm with the code change described below:
- in mysqld configuration file, add: wsrep_provider_options='replicator.causal_read_timeout = PT1S'
- restart mysqld
- check the logs

Inside the galera::ReplicatorSMM::causal_read function, inside the 'try' construct, added the logging code as below:
--------------------------------------
    try
    {
       // ... comment stripped
        gu::datetime::Date wait_until(gu::datetime::Date::calendar() + causal_read_timeout_);
        std::ostringstream os;
        if (gu_likely(co_mode_ != CommitOrder::BYPASS))
        {
            commit_monitor_.wait(cseq, wait_until);
            os.flush(); os << "WSRDBG: causal wait on sequence " << seqno << ", timeout: " << causal_read_timeout_;
            log_error << os.str();
        }
       // ..... rest of code here
--------------------------------------

Fix : please see attached patch and double-check if approach is correct. So far, tests show it up correctly.

Related branches

Revision history for this message
Ovidiu G. (ovidiu-gabor) wrote :

[...] and the patch file (forgot to attach to bug report).

Ovidiu G. (ovidiu-gabor)
summary: - replicator.causal_read_timeout value is not parset from configuration
+ replicator.causal_read_timeout value is not parsed from configuration
Revision history for this message
Alex Yurchenko (ayurchen) wrote :

Ovidiu, thanks for catching this. The fix will go to 2.2 final.

Changed in galera:
assignee: nobody → Alex Yurchenko (ayurchen)
milestone: none → 23.2.2
status: New → In Progress
Changed in galera:
status: In Progress → Fix Committed
Changed in galera:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.