Detect if area under panel is complex or even-toned [$50]

Bug #1473563 reported by Cassidy James Blaede
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Wingpanel
Fix Released
Low
Diego Rocha
elementary Stylesheet
Fix Released
Low
Diego Rocha

Bug Description

For determining the opacity of the panel, Gala should also check if the area under the panel is evenly-toned or more complex.

For example, if a wallpaper under the panel has many small bright spots but is overall dark, currently the panel is set to transparent. This can be problematic when trying to see the indicator icons, clock, or "Applications" text when a bright spot is underneath. In that case, we should still have some opacity to the panel to counteract the bright spots.

Tags: bounty

Related branches

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

For a similar concept applied in Android, see "Color Variants" at https://www.google.com/design/spec/layout/structure.html#structure-system-bars

Revision history for this message
Cassidy James Blaede (cassidyjames) wrote :

Here is an example of when Gala gets it wrong and would be improved by detecting the even-ness of the area under the panel. Check the contrast in the top-right.

Changed in gala:
milestone: none → loki-beta1
status: New → Confirmed
Revision history for this message
Danielle Foré (danrabbit) wrote :
summary: - Detect if area under panel is complex or even-toned
+ Detect if area under panel is complex or even-toned [$50]
tags: added: bounty
Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

Basically, what we need to detect is any case where there is an big horizontal variance of the luminosity like the one in the screenshot. Right now, Gala calculates the color variance, so, maybe that's enough and the fix should be done in Wingpanel instead of Gala.

Relevant code is here:
http://bazaar.launchpad.net/~elementary-pantheon/wingpanel/trunk/view/head:/src/Services/BackgroundManager.vala#L82

Cody Garver (codygarver)
Changed in gala:
importance: Undecided → Medium
Cody Garver (codygarver)
Changed in gala:
importance: Medium → Low
affects: gala → wingpanel
Changed in wingpanel:
milestone: loki-beta1 → none
milestone: none → loki-beta1
Changed in egtk:
status: New → In Progress
assignee: nobody → Diego Rocha (diego-rocha-comp)
Changed in wingpanel:
assignee: nobody → Diego Rocha (diego-rocha-comp)
status: Confirmed → In Progress
Changed in egtk:
status: In Progress → Fix Committed
milestone: none → loki-alpha1
Cody Garver (codygarver)
Changed in wingpanel:
milestone: loki-beta1 → loki-alpha1
status: In Progress → Fix Committed
Changed in egtk:
importance: Undecided → Low
Changed in wingpanel:
status: Fix Committed → Fix Released
Cody Garver (codygarver)
Changed in egtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.