Don't close empty workspace until after I've navigated away. [$25]
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Gala |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Much like bug 1070943, I think closing the last window on the last workspace shouldn't move me to the workspace to the left.
Why? A variety of reasons about my workflow, but a new reason has come up to me lately and maybe other daily users. What happens is that Gala SEGFAULTs way too many times when I close the last window on the last workspace. Attached is a patch that fixed it for me.
I can't fix the SEGFAULT but this not only improves my workflow as it also fixes a very nasty bug. Sure, Gala is on Cerbere for me so what happens is that it restarts but it takes a couple of seconds and I dislike the delay. For people who don't have it on Cerbere, they have to find a way to open a terminal (which is hard without Gala) and type in "gala --replace".
Anyway, another idea if the designers disagree with the previous one would be to have an option for this (no, I don't mean static workspaces which I haven't been using to get the vanilla experience and dogfood it against my own preferences), but something like when dynamic workspaces are activated, should Gala move to the workspace to the left when last window on last workspace is closed? I can code that :>.
Related branches
- Danielle Foré: Approve
-
Diff: 7280 lines (+4505/-2129)28 files modifieddata/Makefile.am (+2/-1)
lib/Utils.vala (+129/-7)
lib/WindowManager.vala (+5/-0)
src/Background/BackgroundCache.vala (+1/-1)
src/Background/BackgroundManager.vala (+3/-2)
src/Background/SlideShow.vala (+8/-14)
src/DragDropAction.vala (+209/-59)
src/InternalUtils.vala (+458/-2)
src/Makefile.am (+10/-4)
src/PluginManager.vala (+1/-1)
src/ShadowEffect.vala (+142/-0)
src/Widgets/AppIcon.vala (+0/-105)
src/Widgets/IconGroup.vala (+622/-0)
src/Widgets/IconGroupContainer.vala (+211/-0)
src/Widgets/MonitorClone.vala (+129/-0)
src/Widgets/MultitaskingView.vala (+483/-0)
src/Widgets/WindowClone.vala (+692/-0)
src/Widgets/WindowCloneContainer.vala (+369/-0)
src/Widgets/WindowOverview.vala (+108/-546)
src/Widgets/WindowSwitcher.vala (+6/-3)
src/Widgets/WindowThumb.vala (+0/-191)
src/Widgets/WorkspaceClone.vala (+333/-0)
src/Widgets/WorkspaceThumb.vala (+0/-583)
src/Widgets/WorkspaceView.vala (+0/-436)
src/WindowListener.vala (+88/-0)
src/WindowManager.vala (+223/-172)
src/WorkspaceManager.vala (+272/-0)
vapi/cogl-fixes.vapi (+1/-2)
Changed in gala: | |
milestone: | none → isis-beta1 |
Changed in gala: | |
status: | New → Confirmed |
summary: |
- Closing the last window on the last workspace + don't close empty workspace until after I've navigated away |
Changed in gala: | |
importance: | Undecided → Medium |
summary: |
- don't close empty workspace until after I've navigated away + don't close empty workspace until after I've navigated away [$15] |
Changed in gala: | |
assignee: | nobody → KJ Lawrence (kjtehprogrammer) |
status: | Confirmed → In Progress |
Changed in gala: | |
status: | In Progress → Confirmed |
assignee: | KJ Lawrence (kjtehprogrammer) → nobody |
summary: |
- don't close empty workspace until after I've navigated away [$15] + Don't close empty workspace until after I've navigated away. [$25] |
Changed in gala: | |
status: | Confirmed → In Progress |
Changed in gala: | |
status: | In Progress → Fix Committed |
Changed in gala: | |
status: | Fix Committed → Fix Released |
It's not supposed to just move to the workspace on the left. It's supposed to go the the previous workspace (left, right, #5, whatever).
The reason is that we only ever have 1 blank workspace at a time. Gala cleans up as you are working so that you don't have a bunch of empty workspaces.