fwts: cpufreq: fix fwts_set paths
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Firmware Test Suite |
Fix Released
|
High
|
Unassigned | ||
Bionic |
Fix Released
|
High
|
Colin Ian King | ||
fwts (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
== SRU justfication, BIONIC ==
Commit 5c782e1abfca ("lib: fwts_set: fix API for fwts_set, add fwts_set_int")
swapped the fwts_set() path and data arguments, resulting in the
cpufreq test creating these weird filenames, each containing the path
to the file it intended to write:
-rw-r--r--. 1 root root 55 Jul 3 15:14 'performance'$'\n'
-rw-r--r--. 1 root root 54 Jul 3 15:14 userspace
== Fix ==
Upstream fwts fix:
From b1593c337b44056
From: Robert Elliott <email address hidden>
Date: Fri, 6 Jul 2018 09:41:06 -0500
Subject: [PATCH] cpufreq: fix fwts_set paths
== Regression Potential ==
This just affects the cpufreq test and so the regression potential is small. With the fix no fwts regression test failures are observed.
This fix is already in fwts in Cosmic and is working fine.
Changed in fwts: | |
importance: | Undecided → High |
status: | New → In Progress |
assignee: | nobody → Colin Ian King (colin-king) |
description: | updated |
Changed in fwts: | |
assignee: | Colin Ian King (colin-king) → nobody |
Changed in fwts (Ubuntu): | |
status: | New → Fix Released |
Changed in fwts: | |
status: | In Progress → Fix Released |
Hello Colin, or anyone else affected,
Accepted fwts into bionic-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ fwts/18. 03.00-0ubuntu3 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification- needed- bionic to verification- done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed- bionic. In either case, without details of your testing we will not be able to proceed.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!