snap version generates garbage files

[Pierre Equoy]

I am working on a tool for Canonical CE-QA team [1] and I wanted to package fwts in the snap in order to report firmware logs for the HWE team to investigate.

I found that the snap version of FWTS (18.06.02) produces some garbage files.

Steps to reproduce
------------------

Prereq:
I'm using snapcraft 2.42.1 (rev1594) from the snap store, running on Ubuntu 18.04.

$ git clone git://kernel.ubuntu.com/hwe/fwts.git
$ cd fwts
$ snapcraft cleanbuild
(...)
Snapping 'fwts' -
Snapped fwts_V18.06.02_amd64.snap
Retrieved fwts_V18.06.02_amd64.snap

$ snap install fwts_V18.06.02_amd64.snap --dangerous --devmode

I then try to run the recommended tests [2], some garbage files appear:

$ sudo fwts -q -r fwts_results.log version cpufreq maxfreq msr mtrr nx virt aspm dmicheck apicedge klog oops esrt uefibootpath uefirtvariable uefirttime uefirtmisc --acpitests --log-level=high
$ ls -latrh
(...)
-rw-r--r-- 1 root root 54 Jul 12 15:16 userspace
-rw-r--r-- 1 root root 54 Jul 12 15:16 'powersave'$'\n'

$ cat userspace
/sys/devices/system/cpu/cpu0/cpufreq/scaling_governor
$ cat 'powersave'$'\n'
/sys/devices/system/cpu/cpu3/cpufreq/scaling_governor

This does not happen when I run the "HWE tests":

$ sudo fwts -q -r fwts_results.log version mtrr virt apicedge klog oops

I cannot reproduce this issue if I use the same version of FWTS from the stable PPA [3].

[1] https://bugs.launchpad.net/qabro/
[2] https://github.com/alexhungce/script-fwts/blob/master/recommend_fwts.sh
[3] https://launchpad.net/~firmware-testing-team/+archive/ubuntu/ppa-fwts-stable/

[Pierre Equoy (pieq)]

I tried the fwts packaged in a snap not locally built (checkbox-oem-qa), and I don't see this issue... It might be related to snapcraft?

[Alex Hung (alexhung)]

This is fixed in fwts 18.07.00. Please give it a try and reopen this bug if the problem remains.