fwts: acpidump: FPDT gets stuck in infinite loop when FPDT data lies about the record length

Bug #1375258 reported by Colin Ian King
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Firmware Test Suite
Fix Released
High
Colin Ian King

Bug Description

Section 5.2.23.4 and 5.2.23.5 Performance Record Formats of the ACPI specification states that the length field is 16 for these two record types. Currently fwts believes this data from the firmware, however, some firmware has been known to set this to zero causing fwts to loop on the dumping of multiple records.

fwts should instead not trust this field and assume it is 16 bytes; anything smaller should be dumped out as a hex dump, otherwise it can be dumped correctly.

Changed in fwts:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin Ian King (colin-king)
summary: - fwts: FPDT gets stuck in infinite loop when FPTD data lies about the
+ fwts: FPDT gets stuck in infinite loop when FPDT data lies about the
record length
Revision history for this message
Colin Ian King (colin-king) wrote :
summary: - fwts: FPDT gets stuck in infinite loop when FPDT data lies about the
- record length
+ fwts: acpidump: FPDT gets stuck in infinite loop when FPDT data lies
+ about the record length
Revision history for this message
Colin Ian King (colin-king) wrote :

Fix committed, commit 352b5167c02fa5ceaa47be6bfc6a327259cf3e0a

Changed in fwts:
status: In Progress → Fix Committed
Changed in fwts:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.