add -ljson-c to automake to allow fwts to build with json-c v 0.11 [PATCH]
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Firmware Test Suite |
Fix Released
|
Medium
|
Colin Ian King |
Bug Description
Building fwts against newer json-c libraries fails because the linker cannot find json-c due to a change introduced in json-c version 0.11. Build fails during linking phase as seen below:
make[3]: Entering directory `/tmp/fwts-
/bin/sh ../libtool --tag=CC --mode=link gcc -g -O2 -ljson -lm -o fwts main.o ac_adapter.o acpidump.o acpiinfo.o acpitables.o apicinstance.o battery.o brightness-helper.o brightness.o autobrightness.o checksum.o crsdump.o prsdump.o cstates.o dmar.o fadt.o fan.o lid.o mcfg.o method.o osilinux.o pcc.o powerbutton.o s3.o s3power.o s4.o syntaxcheck.o wakealarm.o wmi.o apicedge.o bios_info.o bios32.o ebda_region.o ebdadump.o hdaaudio.o memmapdump.o mtrr.o mpcheck.o mpdump.o os2gap.o pciirq.o pnp.o romdump.o cmosdump.o virt.o virt_svm.o virt_vmx.o maxfreq.o cpufreq.o nx.o msr.o microcode.o dmicheck.o hotkey.o hpet_check.o klog.o oops.o version.o aspm.o crs.o maxreadreq.o csm.o uefidump.o uefirttime.o uefirtvariable.o uefirtmisc.o securebootcert.o uefivarinfo.o -Llib/src -lfwts -L../src/acpica -lfwtsacpica
libtool: link: gcc -g -O2 -o .libs/fwts main.o ac_adapter.o acpidump.o acpiinfo.o acpitables.o apicinstance.o battery.o brightness-helper.o brightness.o autobrightness.o checksum.o crsdump.o prsdump.o cstates.o dmar.o fadt.o fan.o lid.o mcfg.o method.o osilinux.o pcc.o powerbutton.o s3.o s3power.o s4.o syntaxcheck.o wakealarm.o wmi.o apicedge.o bios_info.o bios32.o ebda_region.o ebdadump.o hdaaudio.o memmapdump.o mtrr.o mpcheck.o mpdump.o os2gap.o pciirq.o pnp.o romdump.o cmosdump.o virt.o virt_svm.o virt_vmx.o maxfreq.o cpufreq.o nx.o msr.o microcode.o dmicheck.o hotkey.o hpet_check.o klog.o oops.o version.o aspm.o crs.o maxreadreq.o csm.o uefidump.o uefirttime.o uefirtvariable.o uefirtmisc.o securebootcert.o uefivarinfo.o -Llib/src -L../..
/usr/bin/ld: syntaxcheck.o: undefined reference to symbol 'json_object_
/usr/bin/ld: note: 'json_object_
/lib64/
Adding -ljson-c to LDFLAGS for fwts, libfwts_la, and kernelscan fixes the issue. I have tested the fix with the V13.12.00 as well as current git (commit: b98b1b1915a9218
Related branches
Changed in fwts: | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Colin King (colin-king) |
Changed in fwts: | |
milestone: | none → 14.02.00 |
Changed in fwts: | |
status: | In Progress → Fix Committed |
Changed in fwts: | |
status: | Fix Committed → Fix Released |
Thanks Mike, we'll sort that out next week.