The database schema was changed without any tests

Bug #1668249 reported by Igor Gajsin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Igor Gajsin
Nominated for Ocata by Igor Gajsin
Newton
Fix Committed
Medium
Igor Gajsin

Bug Description

There were changes of the nailgun's database in the 634b66df450239378a2dfff2797422c6de053af8 commit for the fuel-web repository. In particular, the were dropped:
* table 'vmware_attributes'
* column 'vmware_attributes_metadata' in the table 'releases'
* column 'vmware_attributes' in the table 'cluster_changes'

Absence of tests for alembic migrations makes the maintainability impact in to the project.

Igor Gajsin (igajsin)
Changed in fuel:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/438473

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/438473
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a8ac320d8f3f386ce6e29dd3207c92db9e17ddf7
Submitter: Jenkins
Branch: master

commit a8ac320d8f3f386ce6e29dd3207c92db9e17ddf7
Author: Igor Gajsin <email address hidden>
Date: Mon Feb 27 15:32:27 2017 +0300

    add tests for alembic migration

    There was the commit that removes vmware. It has alembic migrations,
    but doesn't have any tests for that. This commit fixes that.

    Change-Id: I66090b0a0d7bfbd8e2365ec027fabfefc9d612da
    Closes-Bug: #1668249

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/447574

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/447575

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/447575
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=94b19f4edf893e07092b4291049377214b12813c
Submitter: Jenkins
Branch: stable/newton

commit 94b19f4edf893e07092b4291049377214b12813c
Author: Igor Gajsin <email address hidden>
Date: Mon Feb 27 15:32:27 2017 +0300

    add tests for alembic migration

    There was the commit that removes vmware. It has alembic migrations,
    but doesn't have any tests for that. This commit fixes that.

    Change-Id: I66090b0a0d7bfbd8e2365ec027fabfefc9d612da
    Closes-Bug: #1668249
    (cherry picked from commit a8ac320d8f3f386ce6e29dd3207c92db9e17ddf7)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/ocata)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/447574
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.