Astute do not respect debug option for puppet task

[Vladimir Sharshov]

Detailed bug description:

Run cluster with enable debug option do not affect puppet task which always run with debug disable.

Steps to reproduce:
1. Create cluster
2. Check settings/logging and check that Puppet debug logging is enable (by default it is true)
3. Run cluster deploy
4. Dump logs after deployment
5. Untar logs dump and after untar logs-fuel.tar.gz and check fuel/var/log/remote/node-X.test.domain.local) where node-X is node in cluster, for example node-1

Expected results:
Logs with debug level present in the log
2017-02-01T23:22:59.500811+00:00 debug: (Scope(Class[main])) MODULAR: rsync_core_puppet

Actual result:
Where are no log records with debug level

Reproducibility:
Always

Workaround:
No

Impact:
Such problem significantly decrease ability to debug problem environment

Additional information:

Example of logs with such problem can be found here https://product-ci.infra.mirantis.net/job/10.0.system_test.ubuntu.ha_neutron_tun_scale/168/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/430268

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/430268
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=003a0a0efdbedf51fef943586286e00068175b43
Submitter: Jenkins
Branch: master

commit 003a0a0efdbedf51fef943586286e00068175b43
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Feb 7 17:13:35 2017 +0300

    Astute do not respect debug option for puppet task

    Run cluster with enable debug option do not affect
    puppet task which always run with debug disable.

    It is happened because Nailgun send debug option which
    Astute setup for every task, but puppet task required
    puppet_debug option to control it behavior. This code
    will connect this parameters.

    Change-Id: I8df68105aa699e83673c39a0f03bb22673171d6f
    Closes-Bug: #1662512

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/430713

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/430713
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=5b00f6081d116ca11150036c89570cedb1c70d39
Submitter: Jenkins
Branch: stable/newton

commit 5b00f6081d116ca11150036c89570cedb1c70d39
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Feb 7 17:13:35 2017 +0300

    Astute do not respect debug option for puppet task

    Run cluster with enable debug option do not affect
    puppet task which always run with debug disable.

    It is happened because Nailgun send debug option which
    Astute setup for every task, but puppet task required
    puppet_debug option to control it behavior. This code
    will connect this parameters.

    Change-Id: I8df68105aa699e83673c39a0f03bb22673171d6f
    Closes-Bug: #1662512
    (cherry picked from commit 003a0a0efdbedf51fef943586286e00068175b43)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-astute 11.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/444094

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/444094
Committed: https://git.openstack.org/cgit/openstack/fuel-astute/commit/?id=840392eeaebe52fb7bef092eda987a897475763c
Submitter: Jenkins
Branch: stable/mitaka

commit 840392eeaebe52fb7bef092eda987a897475763c
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Tue Feb 7 17:13:35 2017 +0300

    Astute do not respect debug option for puppet task

    Run cluster with enable debug option do not affect
    puppet task which always run with debug disable.

    It is happened because Nailgun send debug option which
    Astute setup for every task, but puppet task required
    puppet_debug option to control it behavior. This code
    will connect this parameters.

    Change-Id: I8df68105aa699e83673c39a0f03bb22673171d6f
    Closes-Bug: #1662512
    (cherry picked from commit 003a0a0efdbedf51fef943586286e00068175b43)

[TatyanaGladysheva (tgladysheva)]

Verified on 9.2 + mu1 updates.

Before the fix:
There is no debug messages in puppet log:
- in /var/log/remote/node-1.test.domain.local/puppet-apply.log on master node
- in /var/log/puppet.log on controller node

After the fix:
Debug messages are present in the log:
On master node:
[root@nailgun ~]# grep -c debug /var/log/remote/node-1.test.domain.local/puppet-apply.log
176104
On controller node:
root@node-1:~# grep -c debug /var/log/puppet.log
174462