[swarm][ostf] fuel-qa should check cluster state after redeploy

[Valentyn Yakovlev]

Found on #784 snapshot
Steps to reproduce:
            1. Create environment with neutron networking
            2. Add 3 nodes with controller role and 1 node with compute role
            3. Create local mirror
            4. Set local mirror mos as default for environment
            5. Download latest snapshot
            6. Run network verification
            7. Deploy the environment
            8. Run OSTF

Expected result:
 OSTF test are passed

Actual result:
 AssertionError: Failed 1 OSTF tests; should fail 0 tests. Names of failed tests:
  - Check that required services are running (failure) 'nova service-list' command execution failed. Please refer to OpenStack logs for more details.

[Valentyn Yakovlev (vyakovlev)]

https://product-ci.infra.mirantis.net/job/9.x.system_test.ubuntu.add_updated_node_to_environment/93/console

[Oleksiy Molchanov (omolchanov)]

QA, seems you are running commands from the wrong place:

http://paste.openstack.org/show/596201/

[Dmitry Belyaninov (dbelyaninov)]

The reason is:
https://github.com/openstack/fuel-qa/blob/stable/mitaka/fuelweb_test/models/fuel_web_client.py#L3100-L3103

some nodes are in error state after redeploy.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/425595

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/425705

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/428644

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/428644
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=c6a1f7a29d4a083b63d0e6ce5a273de0fd04c923
Submitter: Jenkins
Branch: master

commit c6a1f7a29d4a083b63d0e6ce5a273de0fd04c923
Author: Dmitry Belyaninov <email address hidden>
Date: Thu Jan 26 09:30:45 2017 +0000

    Check status after redeploy

    We should check cluster status and deploy state after
    deploy and redeploy. Current tests did not contain this
    check and fails after deployment on OSTFs run.

    Change-Id: I84adc8981b1486c163425fa0b9506e29650203cf
    Closes-Bug: 1658071

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/425705
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=a9078b29be0af0a270ed967f932ee24675556e42
Submitter: Jenkins
Branch: stable/newton

commit a9078b29be0af0a270ed967f932ee24675556e42
Author: Dmitry Belyaninov <email address hidden>
Date: Thu Jan 26 09:30:45 2017 +0000

    Check status after redeploy

    We should check cluster status and deploy state after
    deploy and redeploy. Current tests did not contain this
    check and fails after deployment on OSTFs run.

    Change-Id: I84adc8981b1486c163425fa0b9506e29650203cf
    Closes-Bug: 1658071

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/425595
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=f18e8191451ca2eef38d48554045b0e2c56c423b
Submitter: Jenkins
Branch: stable/mitaka

commit f18e8191451ca2eef38d48554045b0e2c56c423b
Author: Dmitry Belyaninov <email address hidden>
Date: Thu Jan 26 09:30:45 2017 +0000

    Check status after redeploy

    We should check cluster status and deploy state after
    deploy and redeploy. Current tests did not contain this
    check and fails after deployment on OSTFs run.

    Change-Id: I84adc8981b1486c163425fa0b9506e29650203cf
    Closes-Bug: 1658071

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-qa 11.0.0.0rc1 release candidate.