Fuel for OpenStack

/api/clusters/:id/unassignment handler doesn't reset node pending_addition flag

  1. Series newton
  2. Bug #1644853
Bug #1644853 reported by Julia Aranovich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Stanislaw Bogatkin
Fuel for OpenStack 11.0
Mitaka
Fix Released
High
Stanislaw Bogatkin
Fuel for OpenStack 9.2
Newton
Fix Committed
High
Stanislaw Bogatkin
Fuel for OpenStack 10.1

Bug Description

Steps to reproduce:

1. add some node to environment
2. then delete it using /api/clusters/:id/unassignment handler (send [{id: <node_id>}] data to it)
3. check attributes of the deleted node

Expected result: node.pending_addition = false (node was deleted from environment)
Actual result: node.pending_addition = true

Tags: area-python
Stanislaw Bogatkin (sbogatkin)
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Stanislaw Bogatkin (sbogatkin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/411909

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/413040

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/413041

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/411909
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=064722cca657f12e285f17ea500ba5d46e604f55
Submitter: Jenkins
Branch: master

commit 064722cca657f12e285f17ea500ba5d46e604f55
Author: Stanislaw Bogatkin <email address hidden>
Date: Fri Dec 16 19:39:04 2016 +0300

    Explicitly remove pending_addition flag on discovered node deletion

    As we set pending_addition flag on node assignment, remove it
    on node unassignment accordingly.

    Change-Id: I9ed3d85ad2134b362ab145e7008dc8447590a590
    Closes-Bug: #1644853

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/413041
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a45b0dca6ab7006f30576d4b660bdc141844a299
Submitter: Jenkins
Branch: stable/mitaka

commit a45b0dca6ab7006f30576d4b660bdc141844a299
Author: Stanislaw Bogatkin <email address hidden>
Date: Fri Dec 16 19:39:04 2016 +0300

    Explicitly remove pending_addition flag on discovered node deletion

    As we set pending_addition flag on node assignment, remove it
    on node unassignment accordingly.

    Change-Id: I9ed3d85ad2134b362ab145e7008dc8447590a590
    Closes-Bug: #1644853

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/newton)

Reviewed: https://review.openstack.org/413040
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=4d1082e97da0cc992d9d55c6710c0834dbc455bf
Submitter: Jenkins
Branch: stable/newton

commit 4d1082e97da0cc992d9d55c6710c0834dbc455bf
Author: Stanislaw Bogatkin <email address hidden>
Date: Fri Dec 16 19:39:04 2016 +0300

    Explicitly remove pending_addition flag on discovered node deletion

    As we set pending_addition flag on node assignment, remove it
    on node unassignment accordingly.

    Change-Id: I9ed3d85ad2134b362ab145e7008dc8447590a590
    Closes-Bug: #1644853

Ekaterina Shutova (eshutova)
tags: added: on-verification
Revision history for this message
Ekaterina Shutova (eshutova) wrote :

Verified on 9.2 snapshot #770.

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 11.0.0.0rc1

This issue was fixed in the openstack/fuel-web 11.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.