9.0 Provisioning serializers do not allow for safe attributes get

[Vladimir Kuklin]

When we try to use LCM serializers with pre-9.0 clusters we fail to serialize provisioning

2016-09-08 11:26:22.197 ERROR [7efefe24a880] (manager) Transaction 28 failed.
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/nailgun/transactions/manager.py", line 325, in _execute_async
    self._execute_sync(sub_transaction)
  File "/usr/lib/python2.7/site-packages/nailgun/transactions/manager.py", line 356, in _execute_sync
    _get_expected_state(cluster, nodes),
  File "/usr/lib/python2.7/site-packages/nailgun/transactions/manager.py", line 533, in _get_expected_state
    info = deployment_serializers.serialize_for_lcm(cluster, nodes)
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 950, in serialize_for_lcm
    DeploymentLCMSerializer(), cluster, nodes, ignore_customized
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 935, in _invoke_serializer
    cluster, nodes, ignore_customized=ignore_customized
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 114, in serialize
    self.serialize_generated(cluster, origin_nodes)
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 132, in serialize_generated
    nodes = self.serialize_nodes(common_attrs, nodes)
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 769, in serialize_nodes
    self.serialize_node(common_attrs, node, roles)
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 789, in serialize_node
    self.inject_provision_info(common_attrs, node, serialized_node)
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/deployment_serializers.py", line 854, in inject_provision_info
    common_attrs, node
  File "/usr/lib/python2.7/site-packages/nailgun/orchestrator/provisioning_serializers.py", line 447, in serialize_node
    operator_user = cluster_attrs['operator_user']

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/367326

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/367327

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/367326
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a9e626a3f54b8fe7481d2c31684710108baf01ec
Submitter: Jenkins
Branch: master

commit a9e626a3f54b8fe7481d2c31684710108baf01ec
Author: Vladimir Kuklin <email address hidden>
Date: Thu Sep 8 15:11:49 2016 +0300

    Fix backward compatibility for provisioning serializers with non-root

    Fix an issue when provisioning serializers fail due to absence
    if non-root account attributes

    Change-Id: Iae24ea3b916e881e732fce772cd807a55cc97acb
    Closes-bug: #1621450

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/367327
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5b9e008bb70c2a1a44c85cd762577c6b3ef1990f
Submitter: Jenkins
Branch: stable/mitaka

commit 5b9e008bb70c2a1a44c85cd762577c6b3ef1990f
Author: Vladimir Kuklin <email address hidden>
Date: Thu Sep 8 15:11:49 2016 +0300

    Fix backward compatibility for provisioning serializers with non-root

    Fix an issue when provisioning serializers fail due to absence
    if non-root account attributes

    Change-Id: Iae24ea3b916e881e732fce772cd807a55cc97acb
    Closes-bug: #1621450

[Andrey Lavrentyev (alavrentyev)]

Verified on 9.1 snapshot #264

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 495
cat /etc/fuel_build_number:
 495
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0

UBUNTU_MIRROR_ID=ubuntu-2016-09-14-213640
CENTOS_MIRROR_ID=centos-7.2.1511-2016-05-31-083834
MOS_UBUNTU_MIRROR_ID=9.0-2016-09-14-182322
MOS_CENTOS_OS_MIRROR_ID=os-2016-06-23-135731
MOS_CENTOS_PROPOSED_MIRROR_ID=proposed-2016-09-14-222322
MOS_CENTOS_UPDATES_MIRROR_ID=updates-2016-06-23-135916
MOS_CENTOS_HOLDBACK_MIRROR_ID=holdback-2016-06-23-140047
MOS_CENTOS_HOTFIX_MIRROR_ID=hotfix-2016-07-18-162958
MOS_CENTOS_SECURITY_MIRROR_ID=security-2016-06-23-140002

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0 release.