unable to run --noop on specified set of nodes

Bug #1617993 reported by Ivan Berezovskiy
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Anastasiia Guzikova
Mitaka
Fix Released
High
Anastasiia Guzikova
Newton
Fix Committed
High
Anastasiia Guzikova

Bug Description

Steps to reproduce:
Deploy latest 9.1 env (3 controllers, 3 compute nodes).
Try to find customizations in the env on the node using Noop run feature.

Expected result:
Noop run started and successful.

Actual result:
fuel2 env nodes deploy -e 1 --nodes 1 --noop
usage: fuel2 env nodes deploy [-h] -e ENV -n NODES [NODES ...]
fuel2 env nodes deploy: error: unrecognized arguments: --noop

Also now it's possible to execute:
fuel2 env deploy/redeploy --noop

We should follow this way and use Noop run feature with `fuel2 env nodes deploy` only.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/362079

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-fuelclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/362091

Changed in fuel:
status: New → In Progress
Revision history for this message
Alexandra (aallakhverdieva) wrote :

Configuration: http://pastebin.com/xYFFv9yE
3 controllers + 2 computes + 1 Cinder nodes
Cinder LVM over iSCSI for volumes
Neutron with VLAN segmentation

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/363711

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-fuelclient (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/365767

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-fuelclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/366675

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/362797
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=0a497c7905888689f233f70e1e93bed989b13e9f
Submitter: Jenkins
Branch: stable/mitaka

commit 0a497c7905888689f233f70e1e93bed989b13e9f
Author: Anastasiia Guzikova <email address hidden>
Date: Tue Aug 30 14:51:02 2016 +0300

    Skip provision/deletion tasks if dry/noop run

    Partial-bug: #1617993
    Change-Id: Id28dcc65c20d77ea251452114e8c158e10f5f95c

tags: added: in-stable-mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/366675
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=d50113a78e895d640429ba9ddc4a01f978f034ca
Submitter: Jenkins
Branch: master

commit d50113a78e895d640429ba9ddc4a01f978f034ca
Author: Anastasiia Guzikova <email address hidden>
Date: Mon Sep 5 20:43:18 2016 +0300

    Add --noop to the command: fuel node

    Related-Bug: #1617993
    Change-Id: Ib514888614f40fa91cc2525995371135ed7501e7

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/363711
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=44cd73b56e5f6834a39d56bda4dfbe714de3f5c6
Submitter: Jenkins
Branch: master

commit 44cd73b56e5f6834a39d56bda4dfbe714de3f5c6
Author: Anastasiia Guzikova <email address hidden>
Date: Tue Aug 30 14:51:02 2016 +0300

    Skip provision/deletion tasks if dry/noop run

    Partial-bug: #1617993
    Change-Id: Id28dcc65c20d77ea251452114e8c158e10f5f95c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (stable/mitaka)

Reviewed: https://review.openstack.org/362079
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=78083116f8da5c0f5b47e259fdf2f81ad3516826
Submitter: Jenkins
Branch: stable/mitaka

commit 78083116f8da5c0f5b47e259fdf2f81ad3516826
Author: Anastasiia Guzikova <email address hidden>
Date: Mon Aug 29 15:37:59 2016 +0300

    Noop run on specified set of nodes

    Closes-bug: #1617993
    Depends-on: Id28dcc65c20d77ea251452114e8c158e10f5f95c
    Change-Id: I9a8cfca047aebfff94ac0c9966ea5f73b79fc694

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-fuelclient (master)

Reviewed: https://review.openstack.org/362091
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=7a40b88468be5be3ddbf98108a7fcf0a93408870
Submitter: Jenkins
Branch: master

commit 7a40b88468be5be3ddbf98108a7fcf0a93408870
Author: Anastasiia Guzikova <email address hidden>
Date: Mon Aug 29 15:37:59 2016 +0300

    Noop run on specified set of nodes

    Closes-bug: #1617993
    Depends-on: Id28dcc65c20d77ea251452114e8c158e10f5f95c
    Change-Id: I9a8cfca047aebfff94ac0c9966ea5f73b79fc694

Changed in fuel:
status: In Progress → Fix Committed
tags: added: on-verification
Revision history for this message
TatyanaGladysheva (tgladysheva) wrote :

Verified on 9.1 snapshot #238.

tags: removed: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-fuelclient (stable/mitaka)

Reviewed: https://review.openstack.org/365767
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=b544c5a410fa82d36b7ee766cde413343202062d
Submitter: Jenkins
Branch: stable/mitaka

commit b544c5a410fa82d36b7ee766cde413343202062d
Author: Anastasiia Guzikova <email address hidden>
Date: Mon Sep 5 20:43:18 2016 +0300

    Add --noop to the command: fuel node

    Related-Bug: #1617993
    Change-Id: Ib514888614f40fa91cc2525995371135ed7501e7
    (cherry picked from commit d50113a78e895d640429ba9ddc4a01f978f034ca)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/368361

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-octane (stable/mitaka)

Related fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/368362

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/368361
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=f9d9919da5016668ae28df55fd1c69e5413bb68b
Submitter: Jenkins
Branch: master

commit f9d9919da5016668ae28df55fd1c69e5413bb68b
Author: Ilya Kharin <email address hidden>
Date: Sun Sep 11 01:17:22 2016 +0300

    Set the noop_run parameter to False

    Follow changes in the internal API of fuelclient. The noop_run parameter
    is positional and required now.

    Change-Id: Ie9d3eb765879ed52e5c22de93fbe2cc4bc54fd10
    Related-Bug: #1617993

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-octane (stable/mitaka)

Reviewed: https://review.openstack.org/368362
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=24605fb43701469754951ae03475b0346f957b53
Submitter: Jenkins
Branch: stable/mitaka

commit 24605fb43701469754951ae03475b0346f957b53
Author: Ilya Kharin <email address hidden>
Date: Sun Sep 11 01:17:22 2016 +0300

    Set the noop_run parameter to False

    Follow changes in the internal API of fuelclient. The noop_run parameter
    is positional and required now.

    Change-Id: Ie9d3eb765879ed52e5c22de93fbe2cc4bc54fd10
    Related-Bug: #1617993

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.