provider=apt_fuel doesn't fail deployment if it failed

[Igor Yozhikov]

Detailed bug description
Failed tasks: Task[primary-keystone/1] Stopping the deployment process!'
Snapshot:
https://packaging-ci.infra.mirantis.net/job/9.0-pkg-systest-centos/786/artifact/fuel-qa/logs/fail_error_ceph_rados_gw-fuel-snapshot-2016-05-27_14-18-59.tar.gz

Failed job:
https://packaging-ci.infra.mirantis.net/job/9.0-pkg-systest-centos/786/console

Root Cause:
Looks like Package[keystone](provider=apt_fuel returned success on failure.
From puppet.log:
...
016-05-27 14:13:10 +0000 Package[keystone](provider=apt_fuel) (err): Try 3 of 3 failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install keystone' returned 100: Reading package lists...
Building dependency tree...
Reading state information...
...
Err http://perestroika-repo-tst.infra.mirantis.net/mos-repos//ubuntu/9.0/ mos9.0/main python-oslo.log all 3.3.0-2~u14.04+mos2
  404 Not Found
E: Failed to fetch http://perestroika-repo-tst.infra.mirantis.net/mos-repos//ubuntu/9.0/pool/main/p/python-oslo.log/python-oslo.log_3.3.0-2~u14.04+mos2_all.deb 404 Not Found

E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
2016-05-27 14:13:15 +0000 /Stage[main]/Keystone/Package[keystone]/ensure (notice): ensure changed 'purged' to 'present'
2016-05-27 14:13:15 +0000 /Package[keystone] (info): Scheduling refresh of Anchor[keystone::install::end]
2016-05-27 14:13:15 +0000 /Package[keystone] (info): Scheduling refresh of Anchor[keystone::service::end]
...

Reproducibility:
 -
Workaround:
 -
Impact:
 - Deployment wouldn't not stopped of error and will fail on further steps with error not related to real issue.

Description of the environment:
 Operation system: Ubuntu 14.04
 Versions of components: - ISO 324 (fuel-9.0-324-2016-05-15_02-00-00.iso)
 Reference architecture: -
 Network model: -
 Related projects installed: -
Additional information:
 -

[Dmitry Ilyin (idv1985)]

1) This provider should nor report "success" if it could not actually install the package. It should raise exception
3) Provider should do "apt-get update" after the first failed retry.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/322295

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/322295
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=725f70a748add55dd35e0336654d625872016cb3
Submitter: Jenkins
Branch: master

commit 725f70a748add55dd35e0336654d625872016cb3
Author: Dmitry Ilyin <email address hidden>
Date: Fri May 27 21:36:11 2016 +0300

    Fix and refactor apt_fuel provided

    * Fix broken exception after retry and warnings
    * Add 'apt-get update' after installation failure
    * Refactoring and spec

    Change-Id: I7a6bb26c8110a37aa8c472e23981cbebe868f562
    Closes-Bug: 1586450

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/323871

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/323871
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=fe3c66ffdf46fc678a94f46e586f9da31abef2ed
Submitter: Jenkins
Branch: stable/mitaka

commit fe3c66ffdf46fc678a94f46e586f9da31abef2ed
Author: Dmitry Ilyin <email address hidden>
Date: Fri May 27 21:36:11 2016 +0300

    Fix and refactor apt_fuel provided

    * Fix broken exception after retry and warnings
    * Add 'apt-get update' after installation failure
    * Refactoring and spec

    cherry picked from commit: 725f70a748add55dd35e0336654d625872016cb3
    Change-Id: I7a6bb26c8110a37aa8c472e23981cbebe868f562
    Closes-Bug: 1586450

[Evgeny Sikachev (esikachev)]

verified on 484 iso, mos 9.0