redeployment of node in error state skips many tasks

[Matthew Mosesohn]

Detailed bug description:
 Redeploying an environment with a plugin with changes skips many tasks: plugins_rsync plugins_setup_repositories allocate_hugepages globals hiera setup_repositories sync_time fuel_pkgs
Steps to reproduce:
 1. Deploy a plugin that contains a task that will error (detach-database plugin currently fails)
 2. Fix error in plugin by modifying code on Fuel Master
 3. Redeploy environment
Expected results:
 Should repeat all tasks as necessary
Actual result:
 Only runs rsync_core_puppet and then continues to the plugin task that failed without rsyncing the new code.
Reproducibility:
 <put your information here>
Workaround:
 <put your information here>
Impact:
 <put your information here>
Description of the environment:
 Operation system: <put your information here>
 Versions of components: <put your information here>
 Reference architecture: <put your information here>
 Network model: <put your information here>
 Related projects installed: <put your information here>
Additional information:
 <put your information here>

[Vladimir Khlyunev (vkhlyunev)]

looks like redeployment is not necessary, it can happens any time - reproduced on 9.0mos-362

https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.fuel_plugin_reboot/108/
(snapshot https://product-ci.infra.mirantis.net/job/9.0.system_test.ubuntu.fuel_plugin_reboot/108/artifact/logs/fail_error_deploy_cluster_with_reboot_plugin-fuel-snapshot-2016-05-15_01-10-59.tar.xz )

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bulat Gaifullin (<email address hidden>) on branch: master
Review: https://review.openstack.org/324671
Reason: this fix is not actual anymore.

[Alexey Shtokolov (ashtokolov)]

Fixes:
stable/mitaka https://review.openstack.org/#/c/325343/
master https://review.openstack.org/#/c/325341/

[Andrey Lavrentyev (alavrentyev)]

Wasn't able to reproduce it on 9.0-mos #490

[root@nailgun ~]# shotgun2 short-report | head -n8
cat /etc/fuel_build_id:
 490
cat /etc/fuel_build_number:
 490
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0