Intersection of baremetal network IP range and Ironic IP range (Neutron L3 settings) is not validated

[Julia Aranovich]

Reproduced on 10.0 master.

Steps to reproduce in Fuel UI:

1. create environment (default wizard settings)
2. got to Settings tab and enable Ironic service
3. go to Networks tab and check Use whole CIDR for Baremetal network in default node network group
4. click SaveSettings button

Expected result: the changes can not be saved because of an intersection of baremetal IP range with Ironic IP range from Neutron L3 parameters. Nailgun should return an appropriate error.

Actual result: there is no error from Nailgun, changes are saved successfully.

Fuel UI should also validate this case as well as it is done for Public network IP range and Floating IP range intersection.

[Aleksey Kasatkin (alekseyk-ru)]

Need to add such check into Nailgun (NetworkCheck class). Now we have partial validation here: NetworkCheck.neutron_check_l3_addresses_not_match_subnet_and_broadcast but it does not cover this case.
There should also be a check for intersection with gateways (one is set in Neutron L3 and another is added in case of using multiple node groups).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/315952

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/315952
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6d40cf027d8b0c4dfe5be63825ce4df20b072fcc
Submitter: Jenkins
Branch: master

commit 6d40cf027d8b0c4dfe5be63825ce4df20b072fcc
Author: Krzysztof Szukiełojć <email address hidden>
Date: Fri May 13 10:14:06 2016 +0200

    Check Intersection of baremetal/ironic

    Check Intersection of baremetal network IP range and Ironic IP range.

    Change-Id: I5b4d7ef23a7df059f1a3afa96b6b81108a6001b8
    Closes-Bug: #1569790

[Julia Aranovich (jkirnosova)]

Fuel UI should be fixed also. So, I'm going to move the ticket back to Confirmed and remove area-python tag.