[ci] Job-group 'properties' field is overriten for jobs containing it's own 'properties' field

Bug #1566897 reported by Vladimir Khlyunev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Lesya Novaselskaya
Mitaka
Fix Committed
High
Lesya Novaselskaya
Newton
Fix Committed
High
Lesya Novaselskaya

Bug Description

Detailed bug description:
 At [0] we are describing several env vars which we need in all swarm tests, but if a job contains env vars too [1] - job-groups properties will be overwritten completely instead of updating vars (see [2] and [3] jobs). We should handle this overwriting. Right now this is not critical because fuel-qa's defaults matches most of job-group-related vars but it can hurts in future

[0] https://github.com/fuel-infra/jenkins-jobs/blob/master/servers/new-product-ci/9.0/swarm.tests.yaml#L12
[1] https://github.com/fuel-infra/jenkins-jobs/blob/master/servers/new-product-ci/9.0/swarm.tests.yaml#L45
[2] https://product-ci.infra.mirantis.net/view/9.0_swarm/job/9.0.system_test.ubuntu.thread_3/configure
[3] https://product-ci.infra.mirantis.net/view/9.0_swarm/job/9.0.system_test.ubuntu.thread_7/configure

Tags: area-ci
Ivan (iremizov)
Changed in fuel:
status: New → Confirmed
importance: High → Medium
Revision history for this message
Aleksandra Fedorova (bookwar) wrote :

There is no inheritance at it is expected.

Revision history for this message
Vladimir Khlyunev (vkhlyunev) wrote :

Is there is no inheritance - we should add all remaining parameters from job-group properties to all overwritten jobs - https://review.openstack.org/#/c/284729/4/fuelweb_test/settings.py will break all threads with overwritten FUEL_STATS_HOST

Revision history for this message
Andrey Sledzinskiy (asledzinskiy) wrote :

That problem blocks our activity on removing Mirantis from codebase.
Can we solve it by adding FUEL_STATS_HOST, ANALYTICS_IP to every job properties or some other way ?

Changed in fuel:
importance: Medium → High
Changed in fuel:
milestone: none → 9.0
Revision history for this message
Lesya Novaselskaya (onovaselskaya) wrote :

We're going to hardcode the URL for both variables (to be put in run_system_test.sh):
FUEL_STATS_HOST='fuel-collect-systest.infra.mirantis.net'
ANALYTICS_IP='fuel-stats-systest.infra.mirantis.net'

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix proposed to fuel-infra/jenkins-jobs (master)

Fix proposed to branch: master
Change author: Lesya Novaselskaya <email address hidden>
Review: https://review.fuel-infra.org/19584

Revision history for this message
Lesya Novaselskaya (onovaselskaya) wrote :
Revision history for this message
Lesya Novaselskaya (onovaselskaya) wrote :

TO be added/exported in run_plugin_example_system_test.sh also.

Revision history for this message
Fuel Devops McRobotson (fuel-devops-robot) wrote : Fix merged to fuel-infra/jenkins-jobs (master)

Reviewed: https://review.fuel-infra.org/19584
Submitter: Aleksandra Fedorova <email address hidden>
Branch: master

Commit: 3974cbe268f48401153fe513a676f26f45b4edc4
Author: Lesya Novaselskaya <email address hidden>
Date: Wed Apr 13 14:53:07 2016

Set job-group statistic properties for swarm tests

Since we remove all the Mirantis specific local stuff from codebase,
but still want to use internal statistics-related env variables, let
us hardcode/set them in infra tests instead of swarm ones.

Closes-Bug: #1566897

Change-Id: Ia9c723b6f95b0effe9e480720bd477dd72834961
Signed-off-by: Lesya Novaselskaya <email address hidden>>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.