Nailgun does not validate field "type" in bond configuration

[Aleksey Zvyagintsev]

Version:
 cat /etc/fuel_build_id | 157

 Node network dump:
http://paste2.org/CPLKCsUA

Flow:
1)Create env with :
{'images_ceph': True,
 'mode': 'ha_compact',
 'name': 'lab4-support_mos9_fc_controller_with_ceph',
 'net_provider': 'neutron',
 'net_segment_type': 'vlan',
 'password': 'ceph1',
 'release_id': 2,
 'tenant': 'ceph1',
 'user': 'ceph1',
 'volumes_ceph': True,
 'volumes_lvm': False}

2) Add nodes and set roles
- At this step NW tabs works fine
3) Press deploy
4)UI fail to show nw tabs

[Bug Checker Bot (bug-checker)]

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

[Julia Aranovich (jkirnosova)]

See that no type__ (linux/ovs) specified for bond1 here: http://paste2.org/CPLKCsUA in L549
That's a cause of the JS exception.

Aleksey, did you create bond1 manually in Fuel UI (interfaces configuration screen) or uploaded this predefined interfaces configuration with 2 bonds?

[Aleksey Zvyagintsev (azvyagintsev)]

Looks like issue in nailgun verify:
Whole dump : http://paste2.org/GECDEALc
Command:
                client.put_node_interfaces(
                    [{'id': node['id'],
                      'interfaces': upd_ifs}])
AB Bond section:

ipdb> pp upd_ifs[7]
{'assigned_networks': [{'id': 8, 'name': 'storage'}],
 'bond_properties': {'mode': 'active-backup'},
 'mode': 'active-backup',
 'name': 'bond1',
 'slaves': [{'name': 'enp5s0f2'}, {'name': 'enp5s0f3'}],
 'type': 'bond'}

As we can see, AB bond configuration have luck of parameter
`
    bond_properties:
      type__: "linux"
`
Otherwise, Naigun successfully apply this json, as valid.

So, moving to nailgun bug.

[Aleksey Kasatkin (alekseyk-ru)]

AFAIC, there are two options here:

1. Make type__ mandatory when bond is created via API and check its value (and corresponding bond modes).
2. User should be responsible for type__ and bond modes correctness.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/302914

[Aleksey Kasatkin (alekseyk-ru)]

I don't think it's HIGH as the case when user uses CLI then UI does not work in all situations (mostly because CLI supports more flexible configuration then UI in some cases). Such cases should be described properly.

[Dmitry Pyzhov (dpyzhov)]

Marking the bug as "Won't fix" for 9.0 release because we passed SCF. Please create separate bug for documentation in order to track this task.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergey Slipushenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/302914

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/342157

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/342157
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=205224d573894e90690dbb10997e65f9820613e3
Submitter: Jenkins
Branch: master

commit 205224d573894e90690dbb10997e65f9820613e3
Author: ntymtsiv <email address hidden>
Date: Thu Jul 14 15:46:48 2016 +0300

    Make type__ mandatory for bond creation

    Added validation to bond creating for field 'bond_properties' and
    bond_properties.type__. They are mandatory and bond can not be created
    without type__.
    Allowed modes for dpdkovs and ovs types:
       - active-backup
       - balance-slb'
       - balance-tcp
       - lacp-balance-tcp
    Allowed modes for linux type:
       - active-backup
       - balance-rr
       - balance-xor
       - broadcast
       - 802.3ad
       - balance-tlb
       - balance-alb

    Change-Id: Ic5a443a347b5abbf235e88bd95154b56a627b76f
    Closes-Bug: #1566252

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/fuel-web 10.0.0 release.