Fuel UI does not distinguish hot pluggable plugins

Bug #1566187 reported by Julia Aranovich
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Bulat Gaifullin
Mitaka
Fix Released
High
Bulat Gaifullin
Newton
Fix Committed
High
Bulat Gaifullin

Bug Description

Steps to reproduce in Fuel UI:

1. create default environment, install not hot pluggable plugin to the environment
2. deploy the environment with some nodes
3. go to Settings tab, find the plugin form and enable the plugin.

Expected result: warning should appear about enabling not hot pluggable plugin in deployed environment.

Actual result: no warnings on UI for the plugin.

Solution: need to rename always_editable flag to hot_pluggable in plugins metadata. Fuel UI code now supports hot_pluggable flag only.

Tags: area-python
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/300964
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=706c1fe3fb78542a3e3e1c5ade070de3880cf611
Submitter: Jenkins
Branch: master

commit 706c1fe3fb78542a3e3e1c5ade070de3880cf611
Author: Bulat Gaifullin <email address hidden>
Date: Mon Apr 4 10:30:35 2016 +0300

    Exposed flag 'hot_pluggable' for plugins

    This flag shall be used instead of deprecated 'always_editable'.

    Change-Id: I4cedae66ba03ef5aed08918b194b24ea2fc6dd29
    Closes-Bug: 1566187

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/302632

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/302632
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=5ea7049ae3878d7e4663dcdb9e4c2a264a8d51d9
Submitter: Jenkins
Branch: stable/mitaka

commit 5ea7049ae3878d7e4663dcdb9e4c2a264a8d51d9
Author: Bulat Gaifullin <email address hidden>
Date: Mon Apr 4 10:30:35 2016 +0300

    Exposed flag 'hot_pluggable' for plugins

    This flag shall be used instead of deprecated 'always_editable'.

    Change-Id: I4cedae66ba03ef5aed08918b194b24ea2fc6dd29
    Closes-Bug: 1566187
    (cherry picked from commit 706c1fe3fb78542a3e3e1c5ade070de3880cf611)

tags: added: on-verification
Revision history for this message
Alexey. Kalashnikov (akalashnikov) wrote :

Verified on 9.0-417-mos: Warning message is shown, when plugin enabled

[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 417
cat /etc/fuel_build_number:
 417
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-bootstrap-cli-9.0.0-1.mos284.noarch
 fuel-migrate-9.0.0-1.mos8398.noarch
 fuel_plugin_example_v4-4.0-4.0.0-1.noarch
 rubygem-astute-9.0.0-1.mos746.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8709.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos137.noarch
 fuel-openstack-metadata-9.0.0-1.mos8709.noarch
 fuel-notify-9.0.0-1.mos8398.noarch
 nailgun-mcagents-9.0.0-1.mos746.noarch
 python-fuelclient-9.0.0-1.mos316.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-utils-9.0.0-1.mos8398.noarch
 fuel-setup-9.0.0-1.mos6347.noarch
 fuel-library9.0-9.0.0-1.mos8398.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-agent-9.0.0-1.mos284.noarch
 fuel-ui-9.0.0-1.mos2706.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 fuel-misc-9.0.0-1.mos8398.noarch
 python-packetary-9.0.0-1.mos137.noarch
 fuel-nailgun-9.0.0-1.mos8709.noarch

tags: removed: on-verification
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.