[library] netconfig task is not idempotent

Bug #1524724 reported by Roman Sokolkov
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Sergey Vasilenko
Mitaka
Medium
Sergey Vasilenko
Newton
High
Sergey Vasilenko

Bug Description

I've ran netconfig task on deployed controller and got 33 resources out_of_sync

Environment: MOS 7.0, probably the same for MOS 8.0

How to check:
1) Deploy any environment
2) Run "puppet apply --noop /etc/puppet/modules/osnailyfacter/modular/netconfig/netconfig.pp"
3) Check "grep out_of_sync /var/lib/puppet/state/last_run_summary.yaml"

Expected result:
out_of_sync: 0

Actual result:
out_of_sync: 33

Details:
puppet output - http://paste.openstack.org/show/481457/

Changed in fuel:
milestone: none → 8.0
assignee: nobody → Fuel Library Team (fuel-library)
importance: Undecided → Medium
status: New → Confirmed
tags: added: area-library
tags: added: team-bugfix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/260655

Changed in fuel:
assignee: Fuel Library Team (fuel-library) → Ivan Ponomarev (ivanzipfer)
status: Confirmed → In Progress
Revision history for this message
Roman Sokolkov (rsokolkov) wrote :

Proposed fix is for other bug.

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 8.0 → 9.0
Revision history for this message
Ivan Ponomarev (ivanzipfer) wrote :

Roman,
I agree, anyway my commit partially fix bug related with sysfs which you can find in puppet output.

Changed in fuel:
assignee: Ivan Ponomarev (ivanzipfer) → Sergey Vasilenko (xenolog)
Changed in fuel:
assignee: Sergey Vasilenko (xenolog) → Ivan Ponomarev (ivanzipfer)
Changed in fuel:
assignee: Ivan Ponomarev (ivanzipfer) → Alex Schultz (alex-schultz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/260655
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=05efae8a1c0ed4cda49de334692f1ed7447deb9d
Submitter: Jenkins
Branch: master

commit 05efae8a1c0ed4cda49de334692f1ed7447deb9d
Author: Ivan Ponomarev <email address hidden>
Date: Tue Dec 22 11:20:48 2015 -0600

    fix sysfs idempotence

     - Change notify from sysfs class to sysfs service
     - Remove ubuntu tweak

    Partial-Bug: #1524724
    Change-Id: I93cc68bd0fcc46b7d506f194c0b16e6439f0632d

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/292347

Changed in fuel:
assignee: Alex Schultz (alex-schultz) → Michael Polenchuk (mpolenchuk)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/292347
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=d040c126d922a2495f94e1ce329cb279eea04557
Submitter: Jenkins
Branch: master

commit d040c126d922a2495f94e1ce329cb279eea04557
Author: Michael Polenchuk <email address hidden>
Date: Mon Mar 14 15:11:13 2016 +0300

    Fix sysfs service idempotency

    Sysfs is kind of "apply params" service, so status should always
    return true. Service's resource will prefer the 'status' parameter,
    then 'statuscmd' method, then look in the process table.

    Partial-Bug: #1524724
    Change-Id: I8a13ac4a227195cfb16be89c8fb0a9a9ec3ba1f0

tags: added: keep-in-9.0
Changed in fuel:
assignee: Michael Polenchuk (mpolenchuk) → Sergey Vasilenko (xenolog)
Revision history for this message
Alexey Shtokolov (ashtokolov) wrote :

Since Fuel 9.1 we have noop deployment to detect changes. Netconfig generates a huge list of changed parameters. It leads to ugly UX. Raise to High

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 10.0 → 11.0
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers