dos.py creates env despite of exception

Bug #1517939 reported by Andrey Lavrentyev on 2015-11-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Medium
ElenaRossokhina
Mitaka
Medium
ElenaRossokhina
Newton
Medium
ElenaRossokhina

Bug Description

dos.py creates a new env despite of exception that's related to invalid network pool.
Probably the same behavior can be observed in other similar cases.
This pollutes the env namespace and prevents from creating the new env with the same name with valid data after correction.

Steps to reproduce:
0. check if no 'foo' env via: dos.py list
1. dos.py create --iso-path <path to iso> --node-count 3 --vcpu 4 --ram 4096 --admin-vcpu 4 --admin-ram 4096 --net-pool <improper net pool> foo
2. check if exception occurs
3. check if 'foo' env is in 'dos.py list' output

Expected Behavior: env shouldn't be created and added to the namespace in case of exceptions during creation

Actual Behavior: env is created and added to the namespace

(fuel-devops-venv)me@it:~$ dos.py create --iso-path /path/to/iso --node-count 3 --vcpu 4 --ram 4096 --admin-vcpu 4 --admin-ram 4096 --net-pool 10.109.0.0/29:10.109.0.0/27 moo
Traceback (most recent call last):
  File "/home/me/fuel-devops-venv/bin/dos.py", line 22, in <module>
    main()
  File "/home/me/fuel-devops-venv/local/lib/python2.7/site-packages/devops/shell.py", line 527, in main
    Shell(args).execute()
  File "/home/me/fuel-devops-venv/local/lib/python2.7/site-packages/devops/shell.py", line 41, in execute
    self.commands.get(self.params.command)(self)
  File "/home/me/fuel-devops-venv/local/lib/python2.7/site-packages/devops/shell.py", line 174, in do_create
    prefix=int(prefix))
ValueError: invalid literal for int() with base 10: '10.109.0.0/27'
(fuel-devops-venv)me@it:~$ dos.py list
NAME
------------------------
fuelweb_test_system_test
moo

(fuel-devops-venv)me@it:~$ dos.py version
2.9.12

tags: added: fuel-devops
Ilya Kutukov (ikutukov) on 2015-11-19
Changed in fuel:
assignee: nobody → Fuel DevOps (fuel-devops)
milestone: none → 8.0-updates
Ilya Kutukov (ikutukov) on 2015-11-19
tags: added: area-devops
Changed in fuel:
importance: Undecided → Medium
status: New → Confirmed
milestone: 8.0-updates → 8.0
Igor Shishkin (teran) on 2015-11-19
Changed in fuel:
assignee: Fuel DevOps (fuel-devops) → Fuel QA Team (fuel-qa)
description: updated
Dmitry Pyzhov (dpyzhov) on 2015-12-01
tags: added: area-qa
removed: area-devops
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → ElenaRossokhina (esolomina)

Fix proposed to branch: master
Review: https://review.openstack.org/261274

Changed in fuel:
status: Confirmed → In Progress
Nastya Urlapova (aurlapova) wrote :

Moved to 9.0 due to Medium status.

Changed in fuel:
milestone: 8.0 → 9.0

Fix proposed to branch: master
Review: https://review.openstack.org/291201

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: release/2.9
Review: https://review.openstack.org/291210
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/261274
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/291201
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers