Fuel for OpenStack

fuelmenu saveonly should share class vars with main app

  1. Series newton
  2. Bug #1502110
Bug #1502110 reported by Matthew Mosesohn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Low
Nikita Zubkov
Fuel for OpenStack 10.0
Newton
Fix Committed
Low
Nikita Zubkov
Fuel for OpenStack 10.0

Bug Description

Saveonly mode was written as a workaround for Fuel system tests, but it gets commonly used and ends up introducing bugs that are not present in the normal operation. One step toward this is to share class member variables with the main Fuelmenu class.

Dmitry Klenov (dklenov)
Changed in fuel:
status: New → Confirmed
Dmitry Pyzhov (dpyzhov)
tags: added: area-library
OpenStack Infra (hudson-openstack)
Changed in fuel:
assignee: Matthew Mosesohn (raytrac3r) → Fedor Zhadaev (fzhadaev)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/253374
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=1da9787fa0fc28f38f0066e7617a7ab631292ead
Submitter: Jenkins
Branch: master

commit 1da9787fa0fc28f38f0066e7617a7ab631292ead
Author: Fedor Zhadaev <email address hidden>
Date: Thu Dec 3 20:04:15 2015 +0300

    Refactored 'save_only' mode

     * Use common logic for 'normal' and 'save_only' modes -
       call modules logic in both cases
     * Remove hardcoded default settings
     * Fix 'save' for situation w/o parent section in config
     * Avoid code duplication in 'save' methods
     * (Minor) Fixed imports order in modules

    Change-Id: I448adf4e41429779ce113c6dbe715ba5bf256f2b
    Depends-on: I83c0f90c66944c225ce7642df3a3a2e7b9b83371
    Closes-Bug: #1502110

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

Fix has been reverted

Changed in fuel:
status: Fix Committed → Confirmed
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

Fix has been reverted because of bug #1527734

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/260344

Changed in fuel:
status: Confirmed → In Progress
Fedor Zhadaev (fzhadaev)
Changed in fuel:
milestone: 8.0 → 9.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/262259
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=6ef4d3940bbbfb45f0076efdf31e356d72862c20
Submitter: Jenkins
Branch: master

commit 6ef4d3940bbbfb45f0076efdf31e356d72862c20
Author: slava <email address hidden>
Date: Tue Dec 29 19:13:17 2015 +0300

    Replace yaml with fuelmenu module as yaml parser

    This patch's mission is to wipe out unnecessary import from fuelmenu
    module, in other case, these lines may be failed due to changes in
    fuelmenu module and it will take a lot of effort to fast identify it.

    Change-Id: Ib696846892fa3661c25d7e779392688c1240c553
    Related-Bug: #1502110

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-main (stable/8.0)

Related fix proposed to branch: stable/8.0
Review: https://review.openstack.org/271955

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-main (stable/8.0)

Reviewed: https://review.openstack.org/271955
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=b51da27761d3f62c32660629321c83dd188372a7
Submitter: Jenkins
Branch: stable/8.0

commit b51da27761d3f62c32660629321c83dd188372a7
Author: slava <email address hidden>
Date: Tue Dec 29 19:13:17 2015 +0300

    Replace yaml with fuelmenu module as yaml parser

    This patch's mission is to wipe out unnecessary import from fuelmenu
    module, in other case, these lines may be failed due to changes in
    fuelmenu module and it will take a lot of effort to fast identify it.

    Change-Id: Ib696846892fa3661c25d7e779392688c1240c553
    Related-Bug: #1502110
    (cherry picked from commit 6ef4d3940bbbfb45f0076efdf31e356d72862c20)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-menu (master)

Change abandoned by Fedor Zhadaev (<email address hidden>) on branch: master
Review: https://review.openstack.org/260344
Reason: Outdated. Will be done in another CR.

Fedor Zhadaev (fzhadaev)
Changed in fuel:
status: In Progress → Confirmed
milestone: 9.0 → 10.0
tags: added: area-python module-fuelmenu
removed: area-library
Fedor Zhadaev (fzhadaev)
Changed in fuel:
milestone: 10.0 → 9.0
status: Confirmed → Won't Fix
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/305786

Changed in fuel:
status: Won't Fix → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/310451

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-menu (master)

Change abandoned by Nikita Zubkov (<email address hidden>) on branch: master
Review: https://review.openstack.org/310451
Reason: not needed

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/305786
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=445ee81865d9764cbee5bf34429e61df7fbdbcfe
Submitter: Jenkins
Branch: master

commit 445ee81865d9764cbee5bf34429e61df7fbdbcfe
Author: Fedor Zhadaev <email address hidden>
Date: Thu Dec 3 20:04:15 2015 +0300

    Refactored 'save_only' mode

     * Use common logic for 'normal' and 'save_only' modes -
       call modules logic in both cases

    Change-Id: I4ba533c1b7e9eb9e9e4538bec33b0565a8f8f2f0
    Co-Authored-By: Fedor Zhadaev <email address hidden>
    Baesed-On-Change-Id: Id54f1229915336b8aebdb36562e06e2596c003f1
    Closes-Bug: #1502110

Changed in fuel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.