fuel log rotation should be part of system log rotation schedule

[Alex Schultz]

Stemming from changes related to bug 1461400 and bug 1382515, we should collapse the fuel log rotation actions in with the system log rotation configurations and update the log rotation job to be hourly. Currently the fuel logs are excluded from the standard log rotation schedule and triggered via our own cron task as a different schedule. The following items should be done:

*) Remove exclusion of fuel logrotate configuration from standard system logrotate configuration (possible removal tabooext of .nodaily and/or rename /etc/logrotate.d/fuel.nodaily to just /etc/logrotate.d/fuel)
*) Update global dateext to handle hourly rotation since we may have introduced maxsize which could cause logs to rotate more than once a day
*) Create/copy logrotate job from cron.daily to cron.hourly
*) Ensure upgrade path works correctly (for example 6.1 -> 7.0) and will cleanup our cron tasks

[Bogdan Dobrelya (bogdando)]

The described change request seems nothing more but revert of all recent changes made to the logrotate improvements by the 6.1 dev cycle. What is the point of changing it back and forth and back again, folks? Please, clarify the negative impact of the current logrotate configuration.

[Bogdan Dobrelya (bogdando)]

I mean this bug https://bugs.launchpad.net/fuel/+bug/1382515. This one looks an opposite.

[Alexander Bozhenko (alexbozhenko)]

Current configuration is too complicated to understand and maintain for those who didn't spent a week figuring out how it works.
Also, two rotation schedules caused errors.

[Alex Schultz (alex-schultz)]

This bug isn't necessarily reverting the changes that have been made. The only thing getting changed by this description is bringing the two log rotate configurations and executions together and simplifying how it is executed. With the other bugs/changes we have essentially implemented a secondary logrotate schedule on top of the existing normal logrotate configuration which runs daily. There shouldn't be any reason we couldn't combine the configuration into a single set of configurations and just use the standard logrotate script on an hourly basis. Given that we're adding in maxsize to the global configuration with the other referenced bugs, it should in theory work better for any log files outside of our fuel configuration that may grow at scale and require additional rotation more frequently than daily.

[Vladimir Khlyunev (vkhlyunev)]

As I investigated, the changes are close related to some changes in https://bugs.launchpad.net/fuel/+bug/1461400. Current version of fuel-logrotate works and there is some risks to change and debug it while HCF in progress. But current version is too complicated (run twice an hour, check if logrotate is running via pgrep) and contains pitfalls. I suggest to move changes listed here to 7.0.

[Vladimir Khlyunev (vkhlyunev)]

Addition to the previous comment: I suggest to move _this_ wish-list to 7.0, but it probably will be fixed upstream by https://bugs.launchpad.net/fuel/+bug/1461400 (maybe it's better to merge this bug and 1461400?)

[Bogdan Dobrelya (bogdando)]

This is a feature, we use wishlist for features.