Fuel for OpenStack

IBP Split do_build_image method into a set of smaller ones

  1. Series newton
  2. Bug #1444090
Bug #1444090 reported by Vladimir Kozhukalov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Triaged
Medium
Fuel Sustaining
Fuel for OpenStack 10.0
Mitaka
Won't Fix
Medium
Fuel Python (Deprecated)
Fuel for OpenStack 9.0
Newton
Triaged
Medium
Fuel Sustaining
Fuel for OpenStack 10.0

Bug Description

fuel_agent.manager.do_build_image method is too huge. We need to split it into a set of smaller methods. It is easier to use and test them when they are small. And we also need to add more unit tests for image building.

Alexander Gordeev (a-gordeev)
Changed in fuel:
assignee: Vladimir Kozhukalov (kozhukalov) → Aleksandr Gordeev (a-gordeev)
Alexander Gordeev (a-gordeev)
Changed in fuel:
assignee: Aleksandr Gordeev (a-gordeev) → Fuel Python Team (fuel-python)
tags: added: feature-image-based ibp
Revision history for this message
Vladimir Sharshov (vsharshov) wrote :

This is tech-debt. Moving to 8.0

tags: added: tech-debt
Changed in fuel:
status: Triaged → Won't Fix
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
status: Won't Fix → Triaged
no longer affects: fuel/8.0.x
Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-agent (master)

Change abandoned by Aleksey Zvyagintsev (<email address hidden>) on branch: master
Review: https://review.openstack.org/237682

Vladimir Kozhukalov (kozhukalov)
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Aleksey Zvyagintsev (azvyagintsev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to fuel-agent (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/243229

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to fuel-agent (master)

Reviewed: https://review.openstack.org/243229
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=889ef8f03f899b4feaeda549d631281117e3165e
Submitter: Jenkins
Branch: master

commit 889ef8f03f899b4feaeda549d631281117e3165e
Author: alexz <email address hidden>
Date: Mon Nov 9 19:38:48 2015 +0200

    Split do_build_image

    Cut huge method with few new functions.
    Not clear solution, but its allow us to avoid code duplication

    Implements: blueprint dynamically-build-bootstrap
    Related-Bug: #1444090
    Change-Id: I3b13336d0f2f5e596b362b81dd72b128cb1363aa

Aleksey Zvyagintsev (azvyagintsev)
Changed in fuel:
assignee: Aleksey Zvyagintsev (azvyagintsev) → nobody
Ilya Kutukov (ikutukov)
Changed in fuel:
assignee: nobody → Fuel Python Team (fuel-python)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/240869
Committed: https://git.openstack.org/cgit/openstack/fuel-agent/commit/?id=b3aa429ae15b9f8f5b4514383bb890c4320c5be8
Submitter: Jenkins
Branch: master

commit b3aa429ae15b9f8f5b4514383bb890c4320c5be8
Author: alexz <email address hidden>
Date: Mon Nov 2 16:19:19 2015 +0200

    add manager.do_mkbootstrap func

    do_mkbootstrap func, which adds possibility to build
     custom bootstrap image based on ubuntu-trusty.
    Allows:
    * install custom packages
    * prepare matadata.yaml
    * pack all bootstrap files into archive

    Implements: blueprint dynamically-build-bootstrap
    Related-Bug: #1444090
    Change-Id: Icac658b867fe1c5f5af8da64fd741d7a5f7bb6f9

Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 8.0 → 9.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.