Update tox in Python modules/projects

Bug #1408274 reported by Sebastian Kalinowski
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Confirmed
Low
Annapoornima Koppad
Mitaka
Won't Fix
Low
Fuel Python (Deprecated)
Newton
Confirmed
Low
Annapoornima Koppad

Bug Description

We should update minimum tox version in tox.ini to one of the recent one and remove all the deprecated/integrated into core settings from our tox.ini. For example:

https://github.com/stackforge/fuel-web/blob/4b325a95b0217a26a17f526cb734b3748cb03e12/nailgun/tox.ini#L9

setenv = VIRTUAL_ENV={envdir}

Since tox 1.8 VIRTUAL_ENV var is set by tox directly and it doesn't have to be set in tox.ini anymore.

tox will need to be updated also on our CI servers.

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Actually, I don't even know why it's important to set up this damn variable. I thought it's used for various third-party scripts and not intended for general use. I mean, if we remove it - all should work fine.

Changed in fuel:
status: New → Confirmed
milestone: none → 6.1
Revision history for this message
Sebastian Kalinowski (prmtl) wrote :

It's set to tell that we are in virtualenv - virtualenv sets VIRTUAL_ENV env also.

Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Yep, I know what it does. The point is I don't know why should we have it. I mean, afaik it's a helper stuff for outside world and not intended to be used by tests.

Evgeniy L (rustyrobot)
tags: added: size-s
Dmitry Pyzhov (dpyzhov)
tags: added: tech-debt
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

This bug does not affect build. So we can merge fix even after SCF

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Nikolay Markov (nmarkov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/171108

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
Nikolay Markov (nmarkov) wrote :
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 6.1 → 7.0
Revision history for this message
Nikolay Markov (nmarkov) wrote :

Request for this: https://review.openstack.org/#/c/171108/

Also, looks like this bug is frozen until new tox is in our CI process.

Changed in fuel:
assignee: Nikolay Markov (nmarkov) → Fuel Python Team (fuel-python)
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
status: In Progress → Confirmed
Dmitry Pyzhov (dpyzhov)
Changed in fuel:
milestone: 7.0 → 8.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (master)

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/171108
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

Dmitry Pyzhov (dpyzhov)
tags: added: area-python
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

We passed SCF in 8.0. Moving the bug to 9.0.

Changed in fuel:
milestone: 8.0 → 9.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.