Restriction expression parser: 'insecure' parsed as operator 'in' and 'secure' arg.

Bug #1638916 reported by Alexander Arzhanov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
Medium
Fuel Sustaining
Mitaka
Confirmed
Medium
Fuel Sustaining
Newton
Confirmed
Medium
Fuel Sustaining

Bug Description

We were forced to use an "unsecure" in this restriction https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/fixtures/openstack.yaml#L1714, because we have bug in restriction expression parser, 'insecure' parsed as operator 'in' and 'secure' arg. We tried to fix it by changing t_IN token regexp to r'\sin\s', but it magically brakes other restriction from openstack.yaml.

Related bug https://bugs.launchpad.net/fuel/+bug/1636414

Tags: area-python
Changed in fuel:
importance: Undecided → Medium
milestone: none → 9.2
assignee: nobody → Vitaly Kramskikh (vkramskikh)
tags: added: area-ui
description: updated
Changed in fuel:
milestone: 9.2 → none
milestone: none → 9.2
no longer affects: fuel/mitaka
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/395524

Changed in fuel:
assignee: Vitaly Kramskikh (vkramskikh) → Julia Aranovich (jkirnosova)
status: New → In Progress
Revision history for this message
Julia Aranovich (jkirnosova) wrote :

The case has been checked in dev environment on both stable/mitaka and master branches.
Also, unit test is also passed for the case (https://review.openstack.org/#/c/395524/).
So, jison parser of restriction expressions works properly on UI.

Need to check the issue in Nailgun expression parser.

tags: removed: area-ui
Changed in fuel:
status: In Progress → New
assignee: Julia Aranovich (jkirnosova) → Fuel Sustaining (fuel-sustaining-team)
tags: added: area-python
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-ui (master)

Change abandoned by Julia Aranovich (<email address hidden>) on branch: master
Review: https://review.openstack.org/395524

Changed in fuel:
status: New → Confirmed
Roman Vyalov (r0mikiam)
Changed in fuel:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.