Split @content decorator

Bug #1606211 reported by Dmitry Guryanov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
Medium
Dmitry Guryanov
Mitaka
Fix Committed
Medium
Dmitry Guryanov

Bug Description

Decorator @content does almost everything. Let's split it into 3 decorators:

@handle_errors
@validate
@serialize(exact_mimetypes)

tags: added: area-python
Changed in fuel:
milestone: none → 9.1
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/346957

Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Dmitry Guryanov (dguryanov)
status: Confirmed → In Progress
Revision history for this message
Dmitry Pyzhov (dpyzhov) wrote :

Required for deployment history feature. Targeting to 9.1

tags: added: tech-debt
Changed in fuel:
milestone: 9.1 → 10.0
importance: Low → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/355952

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/346957
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6e31938a0fff264200ddad235ed57398d3ffcb02
Submitter: Jenkins
Branch: master

commit 6e31938a0fff264200ddad235ed57398d3ffcb02
Author: Dmitry Guryanov <email address hidden>
Date: Mon Aug 22 11:46:32 2016 +0300

    Split @content decorator

    Decorator content does too many different actions, so
    let's split it into 3 decorators: @handle_errors,
    @validate and @serialize. We can skip calling @serialize
    in many places, because those methods just raise some
    http error.

    Also I've changed return value of all handlers from
    serialized json (string) to python's structures, lists
    and dicts. So It's become possible to implement different
    serializers and I've added support for YAML output.

    Change-Id: Ia3da3bd809bcca923d53666eca54def78c995f65
    Closes-Bug: #1606211

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/355952
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=c2ae5ea605ac5f119dbac1efb35e344493e60905
Submitter: Jenkins
Branch: stable/mitaka

commit c2ae5ea605ac5f119dbac1efb35e344493e60905
Author: Dmitry Guryanov <email address hidden>
Date: Fri Aug 19 15:25:49 2016 +0300

    Split @content decorator

    Decorator content does too many different actions, so
    let's split it into 3 decorators: @handle_errors,
    @validate and @serialize. We can skip calling @serialize
    in many places, because those methods just raise some
    http error.

    Also I've changed return value of all handlers from
    serialized json (string) to python's structures, lists
    and dicts. So It's become possible to implement different
    serializers and I've added support for YAML output.

    backported from Ia3da3bd809bcca923d53666eca54def78c995f65

    Change-Id: Ia3da3bd809bcca923d53666eca54def78c995f65
    Closes-Bug: #1606211

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/359935

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/360103

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/359935
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=666086a946cbf81676ee4dea3342002eb7b13313
Submitter: Jenkins
Branch: master

commit 666086a946cbf81676ee4dea3342002eb7b13313
Author: Bulat Gaifullin <email address hidden>
Date: Wed Aug 24 17:55:26 2016 +0300

    NodeAssignment handler should return valid json

    Fuel-Client expects valid json for all put and post
    requests, so this patch fixes regress introduced by
    patch: Ia3da3bd809bcca923d53666eca54def78c995f65

    Change-Id: I6066e21504bb39e580609db14e1a4e5ea7d13258
    Closes-Bug: #1606211

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/360103
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=cc0663d4bac900df98238dd880d5fde445c18f17
Submitter: Jenkins
Branch: stable/mitaka

commit cc0663d4bac900df98238dd880d5fde445c18f17
Author: Bulat Gaifullin <email address hidden>
Date: Wed Aug 24 17:55:26 2016 +0300

    NodeAssignment handler should return valid json

    Fuel-Client expects valid json for all put and post
    requests, so this patch fixes regress introduced by
    patch: Ia3da3bd809bcca923d53666eca54def78c995f65

    Change-Id: I6066e21504bb39e580609db14e1a4e5ea7d13258
    Closes-Bug: #1606211

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0rc1

This issue was fixed in the openstack/fuel-web 10.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-web 10.0.0

This issue was fixed in the openstack/fuel-web 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.