Can't upload network template with private interface without vlan tag

[Max Lvov]

Here is template http://pastebin.com/M6LmQnQ3
What I do:
1 Create env
2 Add some nodes to cluster
3 In template remove .999 from prv interface
4 Try to upload

What I expect:
Template uploaded:
What I get:
500 Internal server error ('id')
and no details in any log

Another way:
Do not proceed step 2
Ensure you don't have any nodes in cluster
Upload template.
Add nodes to cluster.

What I expect:
Nodes assigned
What I get:
I can't assign nodes to any role with private network

Also, this bug affected by https://bugs.launchpad.net/fuel/+bug/1539115 which makes troubleshooting very difficult.

[Max Lvov (usrleon)]

This bug seems to appear only if I use private network mapped to physical interface and doesn't appear if use sub-interface like eth0.999
Once I will have access to env, I will attach network template.

[Max Lvov (usrleon)]

Fixed bug cation and description

[Max Lvov (usrleon)]

Sorry, forgot to mention this was on 8.0

[Max Lvov (usrleon)]

Ryan Moe has the fix for that. It works, but he wants to test it before to publish.

[Dmitry Dmitriev (dmdmitriev)]

I have successfully uploaded template without VLAN tag on:

- Fuel 8
- Fuel 8 MU2

Template will be attached.

[Max Lvov (usrleon)]

This patch was created by Ryan Moe and fixed my problem.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/391410

[OpenStack Infra (hudson-openstack)]

Change abandoned by Fuel DevOps Robot (<email address hidden>) on branch: master
Review: https://review.openstack.org/391410
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Max Lvov (usrleon)]

Just affected this bug again on 9.1. Patch again helped.

[Max Lvov (usrleon)]

Some correction:
this time it was not private, but private-like custom network.

[Max Lvov (usrleon)]

Could someone finish that abandoned proposal?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/391410
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=392f3859ff501489517668291b01f7fc46e759c8
Submitter: Jenkins
Branch: master

commit 392f3859ff501489517668291b01f7fc46e759c8
Author: Dmitry Guryanov <email address hidden>
Date: Fri Oct 28 13:20:09 2016 +0300

    Calculation of interface types from templates fixed

    In case of adding port on bond 'ether' type was set
    for interface. This was root cause of the issue -
    bond was processed as nic.

    Closes-Bug: #1602817
    Change-Id: I6a5136ce9ce5398aa6d55c795857769a7a41f7b0

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482896
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=7a9cd4197bc0e1373cc2aeb2f3ff9a5f6a9c7485
Submitter: Jenkins
Branch: stable/mitaka

commit 7a9cd4197bc0e1373cc2aeb2f3ff9a5f6a9c7485
Author: Max Yatsenko <email address hidden>
Date: Wed Jul 12 13:34:03 2017 +0300

    Calculation of interface types from templates fixed

      In case of adding port on bond 'ether' type was set
    for interface. This was root cause of the issue -
    bond was processed as nic.
      This patch was based on [1] patch, but it was
    adapted for 'mitaka'.

    [1] https://review.openstack.org/#/c/391410/

    Closes-Bug: #1602817

    Change-Id: I2fb14eac3874796bfb099db0b681db253351850c