fuel-qa fails when bonding used more than once

Bug #1591746 reported by Sergey Yudin
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Alisa Tselovalnikova
Mitaka
Fix Committed
High
Alisa Tselovalnikova

Bug Description

this code https://github.com/openstack/fuel-qa/blob/master/fuelweb_test/models/fuel_web_client.py#L3150 will fail with 'no such method .lower()' in case we tried to bond more than once.

Step 1:
bond0 being created, all ifaces have mac, code works, all good
Step 2:
bond1 being created, all ifaces _except of bond0_ created on step 1 have mac, code fails

yaml which will 100% fail in attachment

Revision history for this message
Sergey Yudin (tsipa740) wrote :

the code here https://github.com/openstack/fuel-qa/blob/master/fuelweb_test/models/fuel_web_client.py#L3150
must be

- if iface['mac'].lower() in macs]
+ if iface['mac'] and iface['mac'].lower() in macs]

Revision history for this message
Sergey Yudin (tsipa740) wrote :
Sergey Yudin (tsipa740)
summary: - fuel-qa fails when bonding being used with baremetal
+ fuel-qa fails when bonding used more than once
Changed in fuel:
assignee: nobody → Fuel QA Team (fuel-qa)
tags: added: area-qa
Dmitry Klenov (dklenov)
Changed in fuel:
milestone: none → 10.0
Changed in fuel:
importance: Undecided → High
status: New → Confirmed
Changed in fuel:
assignee: Fuel QA Team (fuel-qa) → Alisa Tselovalnikova (atselovalnikova)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/385411

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-qa (master)

Fix proposed to branch: master
Review: https://review.openstack.org/385415

Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (stable/mitaka)

Reviewed: https://review.openstack.org/385411
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=9d0fa9b097a2dab849c5ad8a1eea6aae8757079c
Submitter: Jenkins
Branch: stable/mitaka

commit 9d0fa9b097a2dab849c5ad8a1eea6aae8757079c
Author: Alisa Tselovalnikova <email address hidden>
Date: Wed Oct 12 14:39:41 2016 +0300

    Check mac only for physical interfaces

    Change-Id: I763fabcd849c82fc2abd8873c0c46e4047fbdfa5
    Closes-Bug: #1591746

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-qa (master)

Reviewed: https://review.openstack.org/385415
Committed: https://git.openstack.org/cgit/openstack/fuel-qa/commit/?id=e68c910a448ed7baaaa918daf8b81c43fb06dc12
Submitter: Jenkins
Branch: master

commit e68c910a448ed7baaaa918daf8b81c43fb06dc12
Author: Alisa Tselovalnikova <email address hidden>
Date: Wed Oct 12 14:39:41 2016 +0300

    Check mac only for physical interfaces

    Change-Id: I763fabcd849c82fc2abd8873c0c46e4047fbdfa5
    Closes-Bug: #1591746

tags: added: on-verification
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/fuel-qa 11.0.0.0rc1

This issue was fixed in the openstack/fuel-qa 11.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.