[fuel-main] /etc/fuel_build_id should be created during iso build without any conditions

Bug #1578548 reported by Sergey Kulanov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Sergey Kulanov
Mitaka
Fix Committed
High
Sergey Kulanov

Bug Description

We use file /etc/fuel_build_id as the flag for pre-provisioned master node (CentOS) during master node bootstrapping, eg.:

1)
 # Disable online base MOS repo if we run an ISO installation
[ -f /etc/fuel_build_id ] && yum-config-manager --disable mos${FUEL_RELEASE}* --save

2)
if [ ! -f /etc/fuel_build_id ]; then
sed -i "s|127.0.0.1:8080/ubuntu/x86_64|mirror.fuel-infra.org/mos-repos/ubuntu/${FUEL_RELEASE}|g" "${ASTUTE_YAML}"
ln -s ${wwwdir}/${OPENSTACK_VERSION}/ubuntu ${wwwdir}/ubuntu

This logic always works, because building with jenkins we have defined BUILD_ID variable:

ifdef BUILD_ID
$(BUILD_DIR)/iso/isoroot.done: $(ISOROOT)/fuel_build_id
$(ISOROOT)/fuel_build_id:
 echo "$(BUILD_ID)" > $@
endif

In case if we are building ISO without jenkins or variable BUILD_ID is not defined we are "switching" to online repo usage (preprovisioned master node deployment), which is wrong.

We must always create file fuel_build_id during ISO build

Tags: area-build
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/312874

Roman Vyalov (r0mikiam)
no longer affects: fuel/mitaka
no longer affects: fuel/newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/312874
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=656137de077d3b4c68d34d795ca30d66dd3a5709
Submitter: Jenkins
Branch: master

commit 656137de077d3b4c68d34d795ca30d66dd3a5709
Author: Sergey Kulanov <email address hidden>
Date: Thu May 5 12:23:18 2016 +0300

    Always create /etc/fuel_build_id flag

    We need always create /etc/fuel_build_id flag-file since
    it's used for preprovisioned master node detection. The absence
    of this file means that we are on clean CentOS and should use
    online repos.

    Change-Id: If614549621374cf4714f08152c914b85a448b534
    Closes-bug: #1578548

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/313000

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (stable/mitaka)

Reviewed: https://review.openstack.org/313000
Committed: https://git.openstack.org/cgit/openstack/fuel-main/commit/?id=d66dab3291d492e90c2955575df6ba5f43075c5d
Submitter: Jenkins
Branch: stable/mitaka

commit d66dab3291d492e90c2955575df6ba5f43075c5d
Author: Sergey Kulanov <email address hidden>
Date: Thu May 5 12:23:18 2016 +0300

    Always create /etc/fuel_build_id flag

    We need always create /etc/fuel_build_id flag-file since
    it's used for preprovisioned master node detection. The absence
    of this file means that we are on clean CentOS and should use
    online repos.

    Change-Id: If614549621374cf4714f08152c914b85a448b534
    Closes-bug: #1578548
    (cherry picked from commit 656137de077d3b4c68d34d795ca30d66dd3a5709)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.