A stop action support for an already deployed cluster

[Alexander Kurenyshev]

I want to stop deploying of an already deployed cluster with changed config.

Steps to reproduce:
1) Setup Fuel
2) Create a new cluster
3) Deploy the cluster
4) After successful deploying change some settings to enable Deploy changes button
5) Start a new deployment of the cluster
6) Stop deployment process

Expected behavior:
The deployment is stopped

Actual behavior:
There is an error message: "Stop action is forbidden for the cluster"

Since there is no workaround I set Importance to Critical

Fuel used:
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 213
cat /etc/fuel_build_number:
 213
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6338.noarch
 fuel-misc-9.0.0-1.mos8298.noarch
 python-packetary-9.0.0-1.mos131.noarch
 fuel-openstack-metadata-9.0.0-1.mos8654.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8654.noarch
 python-fuelclient-9.0.0-1.mos309.noarch
 fuel-9.0.0-1.mos6338.noarch
 fuel-nailgun-9.0.0-1.mos8654.noarch
 rubygem-astute-9.0.0-1.mos738.noarch
 fuel-library9.0-9.0.0-1.mos8298.noarch
 fuel-agent-9.0.0-1.mos272.noarch
 fuel-ui-9.0.0-1.mos2659.noarch
 fuel-setup-9.0.0-1.mos6338.noarch
 nailgun-mcagents-9.0.0-1.mos738.noarch
 shotgun-9.0.0-1.mos87.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-bootstrap-cli-9.0.0-1.mos272.noarch
 fuel-migrate-9.0.0-1.mos8298.noarch
 fuelmenu-9.0.0-1.mos268.noarch
 fuel-notify-9.0.0-1.mos8298.noarch
 fuel-ostf-9.0.0-1.mos924.noarch
 fuel-mirror-9.0.0-1.mos131.noarch
 fuel-utils-9.0.0-1.mos8298.noarch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/307395

[Dmitry Klenov (dklenov)]

The bug does not conform definition of critical bug. https://wiki.openstack.org/wiki/Fuel/How_to_contribute. Lowering to High.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/307395
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=74e72b1bbedd7edafb00c777cffdbb2a10fc605b
Submitter: Jenkins
Branch: master

commit 74e72b1bbedd7edafb00c777cffdbb2a10fc605b
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Mon Apr 18 21:01:08 2016 +0300

    Support stop deployment for already deployed cluster with LCM

    Task based deployment (>=9.0) implements save way to stop
    deployment action, so we can enable stop deployment for such
    cluster without restrictions. But it is still need to be
    disabled for old env < 9.0 which was already deployed once[1]

    Add tests

    [1]: https://bugs.launchpad.net/fuel/+bug/1529691

    Change-Id: I4284f70f00c5c0b2db026df748c1f73fcd941bf1
    Closes-Bug: #1571713

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/309057

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/309057
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=d3e51a2e6fc41fcfe7870459299eb8598574994f
Submitter: Jenkins
Branch: stable/mitaka

commit d3e51a2e6fc41fcfe7870459299eb8598574994f
Author: Vladimir Sharshov (warpc) <email address hidden>
Date: Mon Apr 18 21:01:08 2016 +0300

    Support stop deployment for already deployed cluster with LCM

    Task based deployment (>=9.0) implements save way to stop
    deployment action, so we can enable stop deployment for such
    cluster without restrictions. But it is still need to be
    disabled for old env < 9.0 which was already deployed once[1]

    Add tests

    [1]: https://bugs.launchpad.net/fuel/+bug/1529691

    Change-Id: I4284f70f00c5c0b2db026df748c1f73fcd941bf1
    Closes-Bug: #1571713
    (cherry picked from commit 74e72b1bbedd7edafb00c777cffdbb2a10fc605b)

[Egor Kotko (ykotko)]

ISO #326 9.0