octane fuel-restore fails (7.0 -> 8.0)

Bug #1566393 reported by sryabin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Committed
High
Oleg S. Gelbukh
8.0.x
Fix Committed
High
Sergey Abramov
Mitaka
Fix Committed
High
Oleg S. Gelbukh

Bug Description

Detailed bug description:

Steps to reproduce:
 1. Install Fuel Admin node using ISO 7.0
 2. Install fuel-octane from the source code
 3. Create backup of Fuel Admin node configuration (without any env)
 4. Install Fuel Admin node using ISO 8.0
 5. Install fuel-octane from rpm http://perestroika-repo-tst.infra.mirantis.net/mos-repos/centos/mos8.0-centos7-fuel/proposed/x86_64/Packages/fuel-octane-8.0.0-1.mos1110.noarch.rpm
 6. Restore backup:
     octane --debug fuel-restore --from ./fuel7_backup.tar --admin-password admin
Expected results:
 Restore is successfully finished

Actual result:
 Traceback (most recent call last):
  File "/usr/bin/octane", line 10, in <module>
    sys.exit(main())
  File "/usr/lib/python2.7/site-packages/octane/app.py", line 54, in main
    return OctaneApp().run(argv)
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 255, in run
    result = self.run_subcommand(remainder)
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 374, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python2.7/site-packages/cliff/command.py", line 54, in run
    self.take_action(parsed_args)
  File "/usr/lib/python2.7/site-packages/octane/commands/restore.py", line 56, in take_action
    self.get_context(parsed_args))
  File "/usr/lib/python2.7/site-packages/octane/commands/restore.py", line 31, in restore_data
    archivator.restore()
  File "/usr/lib/python2.7/site-packages/octane/handlers/backup_restore/postgres.py", line 96, in restore
    self._post_restore_action()
  File "/usr/lib/python2.7/site-packages/octane/handlers/backup_restore/postgres.py", line 161, in _post_restore_action
    c_id, c_data = line.split("|", 1)
ValueError: need more than 1 value to unpack
Reproducibility:
 100%
Workaround:
  No
Impact:
  Critical
Description of the environment:
fuel-octane-8.0.0-1.mos1110.noarch
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "570"
  build_id: "570"
  fuel-nailgun_sha: "558ca91a854cf29e395940c232911ffb851899c1"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "c2a335b5b725f1b994f78d4c78723d29fa44685a"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "d605bcbabf315382d56d0ce8143458be67c53434"

Additional information:
 No

Changed in fuel:
assignee: nobody → Sergey Abramov (sabramov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (master)

Fix proposed to branch: master
Review: https://review.openstack.org/301776

Changed in fuel:
status: New → In Progress
Changed in fuel:
milestone: none → 8.0-updates
importance: Undecided → Medium
tags: added: area-python
Changed in fuel:
milestone: 8.0-updates → 9.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (master)

Reviewed: https://review.openstack.org/301776
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=fe614b7d2501fa6bd6fe4426724d34c7ad49b806
Submitter: Jenkins
Branch: master

commit fe614b7d2501fa6bd6fe4426724d34c7ad49b806
Author: Sergey Abramov <email address hidden>
Date: Tue Apr 5 18:42:30 2016 +0300

    Fix empty sql list

    Change-Id: Iabca69931e7119eb1e129de9e7ff9d83d798fa8c
    Closes-Bug: #1566393

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
sryabin (sryabin) wrote :

Traceback (most recent call last):
  File "/usr/bin/octane", line 10, in <module>
    sys.exit(main())
  File "/usr/lib/python2.7/site-packages/octane/app.py", line 54, in main
    return OctaneApp().run(argv)
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 255, in run
    result = self.run_subcommand(remainder)
  File "/usr/lib/python2.7/site-packages/cliff/app.py", line 374, in run_subcommand
    result = cmd.run(parsed_args)
  File "/usr/lib/python2.7/site-packages/cliff/command.py", line 54, in run
    self.take_action(parsed_args)
  File "/usr/lib/python2.7/site-packages/octane/commands/restore.py", line 56, in take_action
    self.get_context(parsed_args))
  File "/usr/lib/python2.7/site-packages/octane/commands/restore.py", line 31, in restore_data
    archivator.restore()
  File "/usr/lib/python2.7/site-packages/octane/handlers/backup_restore/postgres.py", line 96, in restore
    self._post_restore_action()
  File "/usr/lib/python2.7/site-packages/octane/handlers/backup_restore/postgres.py", line 162, in _post_restore_action
    c_id, c_data = line.split("|", 1)
ValueError: need more than 1 value to unpack

Revision history for this message
Oleg S. Gelbukh (gelbuhos) wrote :

Need to back port this fix to stable/8.0 as well.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/302411

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/302412

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/8.0)

Reviewed: https://review.openstack.org/302411
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=e13969bd9a890b41e13dc1ed7d32982ad7ec3391
Submitter: Jenkins
Branch: stable/8.0

commit e13969bd9a890b41e13dc1ed7d32982ad7ec3391
Author: Sergey Abramov <email address hidden>
Date: Tue Apr 5 18:42:30 2016 +0300

    Fix empty sql list

    Change-Id: Iabca69931e7119eb1e129de9e7ff9d83d798fa8c
    Closes-Bug: #1566393
    (cherry picked from commit fe614b7d2501fa6bd6fe4426724d34c7ad49b806)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-octane (stable/mitaka)

Change abandoned by Oleg Gelbukh (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/302412
Reason: Stop pseudo-backport madness.

Changed in fuel:
status: In Progress → Fix Committed
tags: added: team-upgrades
tags: added: dev-to-verify
tags: removed: dev-to-verify
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-octane (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/332931

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-octane (stable/mitaka)
Download full text (40.5 KiB)

Reviewed: https://review.openstack.org/332931
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=24f3c396612eb0c69fbf06bab3cebbb9ca829426
Submitter: Jenkins
Branch: stable/mitaka

commit b34d749f1c281dafbdbf155bd86830dc8f2a9aa2
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 21:10:56 2016 +0300

    Support mock==1.8.0 in unit tests

    Use assert_called_once_with instead of assert_called_once that was
    introduced in 2.0.0.

    Change-Id: Ifb7699d4b552d148984961727355f0e23b487c7c

commit d60f1905143bb7576ffd670595de1c4aeafd7b34
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 02:01:52 2016 +0300

    Allow to authorize by the predefined admin_token

    The admin_token_auth middleware is added to keystone pipelines to
    allow authorization by admin_token.

    Change-Id: Ic03150305a669fad1446436a68051fb9aa25b892

commit cc7fab59f44ffef60285f8732d798f52469b2530
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:47:01 2016 +0300

    Reset default_domain_id before the keystone task

    The default_domain_id should be removed from keystone.conf after restore
    of DB and before to apply the keystone puppet task to avoid of using the
    configured domain as a default.

    Change-Id: I05a6c48532e8042496b3d8ccef53d65bf8c44653

commit e3f82399d567dbcfc1ae9a1ecbddba7bf5028fc8
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:32:47 2016 +0300

    Add helper function to iterate over parameters

    The helpers.iterate_parameters function allows to iterate over lines of
    INI-like files along with a context of information, such section,
    parameter and value.

    Change-Id: I55b179118116fd5dacf100754057ea6589782dc2

commit 5ed370a4fbb3369d0f75873d205ac7f0c655f93a
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:18:05 2016 +0300

    Add update_file context manager for local files

    The subprocess.update_file function provides an ability to update
    content of a local file by iterating over lines of an original file and
    forming a result content in a temporary file to replace the original
    file in the end. This function is very useful to change configuration
    files.

    Change-Id: I433a5da67887b231400dd63131799019f45c277c

commit 58f31e6c5f408630c42565ee53de6b59457bc84c
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 14:34:03 2016 +0000

    Escape passwords passed to openstack client

    If special symbols are used in password for 'admin' user in
    OpenStack, octane passes them to command line client as is
    and it breaks shell.

    Properly escape the password before passing it to subprocess.

    Change-Id: Iad635aec6d5b5cc32975937e00205b7e89dc99d9
    Closes-bug: 1585960

commit 896aba1191eeb59cf85cc8be6a2ae67e08b76070
Author: Yuriy Taraday <email address hidden>
Date: Wed Jun 22 15:28:45 2016 +0300

    Add absolute_import to util/docker.py to avoid local tempfile module

    Closes-Bug: 1595156
    Change-Id: I9484efce6fa7aec1b41cf592f9e9768d85931fa7

commit 46586a62df962b2ce00b5d8a63f6fd34c920a1f4
Author: Oleg Gelbukh <email address hidden>
Date: Thu M...

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.