Nailgun silently ignores extension load failure

Bug #1555005 reported by Yuriy Taraday
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Medium
Ryan Moe
Mitaka
Medium
Yuriy Taraday
Newton
Medium
Ryan Moe

Bug Description

If extension fails to load (due to ImportError or error in some initialization logic within the extension) Nailgun silently ignores such error.

We should make Nailgun fail if one of extensions fails.

Changed in fuel:
milestone: none → 9.0
assignee: nobody → Fuel Python Team (fuel-python)
tags: added: module-nailgun
Changed in fuel:
status: New → Confirmed
Changed in fuel:
importance: Undecided → Medium
Revision history for this message
Bug Checker Bot (bug-checker) wrote : Autochecker

(This check performed automatically)
Please, make sure that bug description contains the following sections filled in with the appropriate data related to the bug you are describing:

actual result

version

expected result

steps to reproduce

For more detailed information on the contents of each of the listed sections see https://wiki.openstack.org/wiki/Fuel/How_to_contribute#Here_is_how_you_file_a_bug

tags: added: need-info
Revision history for this message
Sylwester Brzeczkowski (sbrzeczkowski) wrote :

ExtensionManager should get 'on_load_failture_callback' argument with function which will raise some custom "CannotLoadExtensionError" or something.

[0] https://github.com/openstack/fuel-web/blob/master/nailgun/nailgun/extensions/manager.py#L38-L39

Changed in fuel:
status: Confirmed → Triaged
Revision history for this message
Yuriy Taraday (yorik-sar) wrote :

In Octane we do this by just raising the exception that is being handled in on_load_failure_callback: https://github.com/openstack/fuel-octane/blob/master/octane/handlers/__init__.py#L25

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/304867

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Ryan Moe (rmoe)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/304867
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=b20d67712e6815f709b0ab80f393e1c2303906d1
Submitter: Jenkins
Branch: master

commit b20d67712e6815f709b0ab80f393e1c2303906d1
Author: Ryan Moe <email address hidden>
Date: Tue Apr 12 13:47:19 2016 -0700

    Don't ignore failure to load extensions

    When an extension fails to load a message will be logged along with
    the exception raised by the extension. The exception will be
    re-raised.

    Change-Id: Ic8e8931a34f59102dbcd1f5c5dc48d562cabedff
    Closes-bug: #1555005

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Yuriy Taraday (yorik-sar) wrote :

Why is this change in "Won't fix" for mitaka? It causes some pain for mitaka development.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/360513

Revision history for this message
Yuriy Taraday (yorik-sar) wrote :

Bug has been reintroduced in master by https://review.openstack.org/342880

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-web (stable/mitaka)

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/mitaka
Review: https://review.opendev.org/360513
Reason: This repo is retired now, no further work will get merged.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers