[fuelmenu] @ is not recognised as special character

Bug #1579754 reported by Serg Lystopad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Maksim Malchuk
8.0.x
Fix Released
High
Maksim Malchuk
Mitaka
Fix Released
High
Maksim Malchuk
Newton
Fix Released
High
Maksim Malchuk

Bug Description

Detailed bug description:
 `check` action does not recognise '@' character as special

Steps to reproduce:
 install fuel8 -> enter fuelmenu -> set 'Fuel User' password to 'Mm1234567@' -> hit `check` button

Expected results:
 password verification is succeed

Actual result:
 Warning message at the bottom of the screen
 http://img.ctrlv.in/img/16/05/09/573087b1c8058.png

Reproducibility:
 reproducible

Impact:
 user experience

Description of the environment:
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "570"
  build_id: "570"
  fuel-nailgun_sha: "558ca91a854cf29e395940c232911ffb851899c1"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "c2a335b5b725f1b994f78d4c78723d29fa44685a"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "d605bcbabf315382d56d0ce8143458be67c53434"

Maciej Relewicz (rlu)
Changed in fuel:
importance: Undecided → High
milestone: none → 8.0-updates
assignee: nobody → Fuel Sustaining (fuel-sustaining-team)
status: New → Confirmed
tags: added: area-python
Changed in fuel:
assignee: Fuel Sustaining (fuel-sustaining-team) → Maksim Malchuk (mmalchuk)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (master)

Fix proposed to branch: master
Review: https://review.openstack.org/314104

Revision history for this message
Matthew Mosesohn (raytrac3r) wrote :

Is this really high priority? Sounds like a medium bug to me

Revision history for this message
Maksim Malchuk (mmalchuk) wrote :

I agree with Sergiy, Security bugs should be High by default.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (master)

Reviewed: https://review.openstack.org/314104
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=e4af61ac6d65f1f8c1732abc4b94271843e128ac
Submitter: Jenkins
Branch: master

commit e4af61ac6d65f1f8c1732abc4b94271843e128ac
Author: Maksim Malchuk <email address hidden>
Date: Mon May 9 16:31:17 2016 +0300

    Add forgotten @ symbol to the special character list

    Change-Id: I5e9f90fc965a4a421dd95295feac45bc9f430fd1
    Closes-Bug: #1579754
    Signed-off-by: Maksim Malchuk <email address hidden>

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/314480

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-menu (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/314481

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-menu (stable/mitaka)

Reviewed: https://review.openstack.org/314480
Committed: https://git.openstack.org/cgit/openstack/fuel-menu/commit/?id=98593fab3e38a7b83923242d054c6ac4fc102288
Submitter: Jenkins
Branch: stable/mitaka

commit 98593fab3e38a7b83923242d054c6ac4fc102288
Author: Maksim Malchuk <email address hidden>
Date: Mon May 9 16:31:17 2016 +0300

    Add forgotten @ symbol to the special character list

    Change-Id: I5e9f90fc965a4a421dd95295feac45bc9f430fd1
    Closes-Bug: #1579754
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit e4af61ac6d65f1f8c1732abc4b94271843e128ac)

tags: added: on-verification
Revision history for this message
ElenaRossokhina (esolomina) wrote :

Verified on 9.0 iso#308
cat /etc/fuel_build_id:
 308
cat /etc/fuel_build_number:
 308
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6344.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-openstack-metadata-9.0.0-1.mos8681.noarch
 python-fuelclient-9.0.0-1.mos313.noarch
 fuel-9.0.0-1.mos6344.noarch
 fuel-nailgun-9.0.0-1.mos8681.noarch
 rubygem-astute-9.0.0-1.mos742.noarch
 fuel-misc-9.0.0-1.mos8338.noarch
 fuel-library9.0-9.0.0-1.mos8338.noarch
 shotgun-9.0.0-1.mos88.noarch
 fuel-agent-9.0.0-1.mos276.noarch
 fuel-ui-9.0.0-1.mos2677.noarch
 fuel-setup-9.0.0-1.mos6344.noarch
 nailgun-mcagents-9.0.0-1.mos742.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8681.noarch
 python-packetary-9.0.0-1.mos135.noarch
 fuel-bootstrap-cli-9.0.0-1.mos276.noarch
 fuel-migrate-9.0.0-1.mos8338.noarch
 fuel-mirror-9.0.0-1.mos135.noarch
 fuel-notify-9.0.0-1.mos8338.noarch
 fuel-ostf-9.0.0-1.mos933.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-utils-9.0.0-1.mos8338.noarch

tags: removed: on-verification
Revision history for this message
Dmitry Belyaninov (dbelyaninov) wrote :

Verified on Newton #1556 iso.

Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-menu (stable/8.0)

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/8.0
Review: https://review.opendev.org/314481
Reason: This repo is retired now, no further work will get merged.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.