Fuel for OpenStack

Don't set default value for "workers" in heat-api section of the heat.conf

Series 8.0.x
Bug #1545986

Bug #1545986 reported by Sergey Kraynev on 2016-02-16

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Fuel for OpenStack	Invalid	High	MOS Heat	Fuel for OpenStack 10.0
8.0.x	In Progress	High	MOS Maintenance	Fuel for OpenStack 8.0-updates
Mitaka	Invalid	High	MOS Heat	Fuel for OpenStack 9.0
Newton	Invalid	High	MOS Heat	Fuel for OpenStack 10.0

Bug Description

Heat changes default value of 'workers' option for heat-api section in heat.conf

- In Kilo it was 0,
- In Liberty it is calculated by Heat based on numbers of processors, so we should not set this value in heat.conf file
- In Mitaka calculations based on number of processors was hidden under 0 default value, so using 0 as default is correct again.

We have puppets correct for Mitaka and Kilo, However to be inline with community we should update default for Liberty (MOS 8.0)

Tags:

Ivan Berezovskiy (iberezovskiy) on 2016-02-16

Changed in fuel:
status:	New → Confirmed

Vitaly Sedelnik (vsedelnik) on 2016-03-25

Changed in fuel:
milestone:	8.0-mu-1 → 8.0-updates

Ivan Berezovskiy (iberezovskiy) on 2016-03-25

Changed in fuel:
assignee:	MOS Puppet Team (mos-puppet) → Alexey Deryugin (velovec)

Revision history for this message

Fuel Devops McRobotson (fuel-devops-robot) wrote on 2016-04-13: Fix proposed to puppet-modules/puppet-heat (mos-8.0)

Fix proposed to branch: mos-8.0
Change author: Alexey Deryugin <email address hidden>
Review: https://review.fuel-infra.org/19579

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

Fuel Devops McRobotson (fuel-devops-robot) wrote on 2016-04-14: Fix merged to puppet-modules/puppet-heat (mos-8.0)

Reviewed: https://review.fuel-infra.org/19579
Submitter: Ivan Berezovskiy <email address hidden>
Branch: mos-8.0

Commit: cebf2afeb8a2f585985c5e1f72a2babee75a3816
Author: Alexey Deryugin <email address hidden>
Date: Thu Apr 14 16:27:08 2016

Don't set default value for workers in heat-api section of the heat.conf

In Liberty api worker count is calculated by Heat based on number of processors,
so we should not set this value in heat.conf file.

Change-Id: I9552170d16dfcefc9529b5859c39ef8cc052222f
Closes-Bug: #1545986

Changed in fuel:
status:	In Progress → Fix Committed

Alexey Deryugin (velovec) on 2016-05-19

Changed in fuel:
status:	Fix Committed → In Progress

Dmitry Klenov (dklenov) on 2016-05-19

tags:

added: area-mos

Revision history for this message

Sergey Kraynev (skraynev) wrote on 2016-05-20:

I have marked this bug as Invalid, because according description and current code does not require any changes for these releases.
Also look like fix for mos 8.0 was merged long time ago, I will wait approve about it from Ivan Berezovskiy

Revision history for this message

Ivan Berezovskiy (iberezovskiy) wrote on 2016-05-20:

In Fuel 8.0 we don't override heat services workers from top manifests, so this patch https://review.fuel-infra.org/#/c/19579/ is enough to make this parameter is automatically calculated by Heat itself.