Selective SSL code supposed to use textarea instead of file for keys saving

Bug #1528606 reported by Stanislaw Bogatkin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Stanislaw Bogatkin
8.0.x
In Progress
High
Stanislaw Bogatkin

Bug Description

In current implementation of selective SSL task ssl_keys_saving supposed that there are textarea fields for keys saving. But Fuel 7.0 implements special 'file' field for that, so it should be used instead of 'textarea's.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (master)

Fix proposed to branch: master
Review: https://review.openstack.org/260585

Changed in fuel:
status: New → In Progress
Maciej Relewicz (rlu)
tags: added: area-library
tags: added: team-bugfix
Revision history for this message
Aleksandr Didenko (adidenko) wrote :

Does not look like high priority bug for 8.0. So I've marked it as "medium" and "won't fix" since we've passed SCF already.

Changed in fuel:
milestone: 8.0 → 9.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-library (master)

Reviewed: https://review.openstack.org/260585
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=f3663d54a01c155559a0ae0d4434ff5cd7f7f9a1
Submitter: Jenkins
Branch: master

commit f3663d54a01c155559a0ae0d4434ff5cd7f7f9a1
Author: Stanislaw Bogatkin <email address hidden>
Date: Tue Dec 22 18:20:59 2015 +0300

    Change way to pull fields for TLS certificates

    Change-Id: Ibc55d98ffc8b8464fd4ca4cdce622ceb1b8a6758
    Closes-Bug: #1528606

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
Stanislaw Bogatkin (sbogatkin) wrote :

Seems that it is still high for 8.0 because of https://bugs.launchpad.net/fuel/+bug/1528622

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-library (stable/8.0)

Fix proposed to branch: stable/8.0
Review: https://review.openstack.org/280681

Revision history for this message
Stanislaw Bogatkin (sbogatkin) wrote :
Revision history for this message
Mikhail Samoylov (msamoylov) wrote :

We need this fix (https://review.openstack.org/#/c/280681/) for fuel 8.0 because puppet task failed (because puppet manifest don't know about content field) when we using ssl_hash.
Output for puppet job ssl_keys_saving.pp:
http://paste.openstack.org/show/487104/

Astute.yaml config for ssl_hash:
http://paste.openstack.org/show/487105/

Revision history for this message
Stanislaw Bogatkin (sbogatkin) wrote :

We talk with Nastya U. and decide that this will be done as a part of mu updates, cause user impact is not so high. Real case for this is the case when user disables public ssl and enables selective ssl instead. As we don't have an UI in 8.0 by default for this and this is not so demanded feature for users, move this to mu-1.

Revision history for this message
Maksym Strukov (unbelll) wrote :

Verified in 9.0-376

Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on fuel-library (stable/8.0)

Change abandoned by Andreas Jaeger (<email address hidden>) on branch: stable/8.0
Review: https://review.opendev.org/280681
Reason: This repo is retired now, no further work will get merged.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.