Can't open Settings tab for 5.1.1 env

[Oleg S. Gelbukh]

Steps to reproduce:

1. Install Fuel 5.1.1
2. Deploy environment with 5.1.1 version
3. Upgrade Fuel Master to 6.0
4. Upgrade Fuel Master to 6.1
5. Open Environment in the Web UI
6. Select 'Settings' tab

Expected results:
Page displays Settings for the environment

Actual results:

Forever hangs with green progress bar instead of tab's contents.
While inspecting the page, following error found:

Uncaught TypeError: Value of networking_parameters:net_l23_provider? is undefined. Set options.strict to false to allow undefined values.

In Nailgun DB, if you select 'editable' attributes from clusters table, you'll see the following condition attribute that triggers the error:

[root@fuel lib]# echo "SELECT editable FROM attributes WHERE cluster_id=3;" | psql -At postresql://nailgun@localhost/nailgun | python -m json.tool | grep provider\?
                    "condition": "cluster:net_provider != 'neutron' or networking_parameters:net_l23_provider? != 'nsx'"

[Vitaly Kramskikh (vkramskikh)]

It seems some migration which remove '?' signs from expressions didn't work. But anyway, should we support upgrades from such old releases?

[Oleg S. Gelbukh (gelbuhos)]

We expect to be able to upgrade Fuel Master from 5.1.1 to 6.1, and then upgrade the cluster deployed by 5.1.1. However, upgrade procedure doesn't directly involve or depend on UI.

[Vitaly Kramskikh (vkramskikh)]

https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/utils/migration.py#L74-L77

Here is the procedure which removes '?' signs from expressions during DB migration. It is used only during 5.1 -> 6.0 upgrade ('?' sign support was removed in 6.0). Something seems to be wrong with it

[Oleg S. Gelbukh (gelbuhos)]

This is applied only to the release metadata, while in cluster metadata the incorrect format remains. As we have to upgrade clusters from 5.1.1 to 7.0, it is possible to add it in 7.0 and then backport if needed to 6.0 or 6.1 as a part of MU.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/208968

[OpenStack Infra (hudson-openstack)]

Change abandoned by Oleg Gelbukh (<email address hidden>) on branch: master
Review: https://review.openstack.org/208968
Reason: Won't fix