make process should fail on issues with docker operations

[Sergey Kulanov]

we need somehow to catch issues with docker operation.

For simple example:
http://jenkins-product.srt.mirantis.net:8080/view/custom_iso/job/custom_6.1_iso/1314/consoleFull

Step 7 : RUN yum install -y shotgun fuel-image fuel-agent fuel-provisioning-scripts; mkdir -p /opt/nailgun/bin /var/www/nailgun/dump; ln -s /usr/bin/nailgun_dump /opt/nailgun/bin/nailgun_dump
 ---> Running in accd08cc5a22
Loaded plugins: fastestmirror, priorities
Loading mirror speeds from cached hostfile
Setting up Install Process
No package fuel-image available.
No package fuel-agent available.
No package fuel-provisioning-scripts available.
Resolving Dependencies
--> Running transaction check
---> Package shotgun.noarch 0:6.1.0-7104.1 will be installed
--> Processing Dependency: xz for package: shotgun-6.1.0-7104.1.noarch
--> Running transaction check
---> Package xz.x86_64 0:4.999.9-0.3.beta.20091007git.el6 will be installed
--> Finished Dependency Resolution

Dependencies Resolved

================================================================================
 Package Arch Version Repository Size
================================================================================
Installing:
 shotgun noarch 6.1.0-7104.1 nailgun 31 k
Installing for dependencies:
 xz x86_64 4.999.9-0.3.beta.20091007git.el6 nailgun 137 k

Transaction Summary
================================================================================
Install 2 Package(s)

Total download size: 168 k
Installed size: 563 k
Downloading Packages:
--------------------------------------------------------------------------------
Total 41 MB/s | 168 kB 00:00
Running rpm_check_debug
Running Transaction Test
Transaction Test Succeeded
Running Transaction

  Installing : xz-4.999.9-0.3.beta.20091007git.el6.x86_64 1/2

  Installing : shotgun-6.1.0-7104.1.noarch 2/2

  Verifying : shotgun-6.1.0-7104.1.noarch 1/2

  Verifying : xz-4.999.9-0.3.beta.20091007git.el6.x86_64 2/2

If we don't have some package in local mirror then no packages will be installed in docker container. We need somehow to catch such issues, to be sure that the docker environment created in proper way

[Matthew Mosesohn (raytrac3r)]

yum can't fail on multipackage installs like this. The best way is to modify the puppet manifests to ensure every package. That way it will fail for sure. The yum install early on is intended to save time wasted in puppet
I can make a patch to mcollective container puppet to ensure these packages are all installed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/208558

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/209511

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/209511
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=ff44a40c2953ebe5a7a983e1a69c073c8ab33a42
Submitter: Jenkins
Branch: master

commit ff44a40c2953ebe5a7a983e1a69c073c8ab33a42
Author: Matthew Mosesohn <email address hidden>
Date: Wed Aug 5 16:13:45 2015 +0300

    Fail on any yum install error during docker build

    Yum returns 0 on partial failures, so the only way around
    is to run separate `yum install` commands. This ensures
    that the build fails early on, instead of at a later point,
    wasting a deployer's time.

    Change-Id: I4a85cd328c0d31c193c85f02c042ee5405666e5f
    Partial-Bug: #1461052

[Matthew Mosesohn (raytrac3r)]

https://review.openstack.org/#/c/208558/ delayed to 8.0.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/214749

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/214749
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=f1b4526fa1b84c894d7e663e2c5f14eb497323af
Submitter: Jenkins
Branch: master

commit f1b4526fa1b84c894d7e663e2c5f14eb497323af
Author: Matthew Mosesohn <email address hidden>
Date: Wed Aug 19 21:45:43 2015 +0300

    Add sleep for ext config, refactor bootstrap_admin config

    This unbinds the waiting period for enabling external configuration
    of Fuel Master and fuelmenu. Now after fuelmenu runs (enabled or
    not), there is an optional 3000s sleep that is activated when Fuel
    is installed with wait_for_external_config=yes as a kernel parameter.

    This new workflow expects fuel-qa scripts to ssh in, check for
    process named "wait_for_external_config" and then to run
    "pkill -f wait_for_external_config"

    Also refactored showmenu option to use a new config file
    /etc/fuel/bootstrap_admin_node.conf.

    Change-Id: I08686ced0b43ed35c5fcbbe4d2c9102b3483ee0b
    Partial-Bug: #1461052

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/208558
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=ae532bda361f7c0136ba098de14d6d464397b8b5
Submitter: Jenkins
Branch: master

commit ae532bda361f7c0136ba098de14d6d464397b8b5
Author: Matthew Mosesohn <email address hidden>
Date: Mon Aug 3 19:42:28 2015 +0300

    Ensure mcollective container packages

    Rewrote class nailgun::mcollective to install
    necessary packages for mcollective container.
    The old nailgun::mcollective is long since
    obsolete.

    Change-Id: Ie6a53cc2ce05db5dfb6e6ea915ee5880cf125940
    Closes-Bug: #1461052