Fix calculation of erlang thread pool size for rabbitmq
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Fuel for OpenStack |
Fix Committed
|
Medium
|
Alexey Lebedeff | ||
7.0.x |
Fix Released
|
Medium
|
MOS Maintenance | ||
8.0.x |
Fix Released
|
Medium
|
MOS Maintenance | ||
Mitaka |
Fix Committed
|
Medium
|
Alexey Lebedeff |
Bug Description
Detailed bug description:
https:/
rabbit uses separate param RABBITMQ_
We need:
- Switch fuel to using RABBITMQ_
- Maybe update defaults calculation in fuel, so they'll be the same
Steps to reproduce:
Run following command on a controller and observe that erlang runtime was passed 2 '-A' options:
ps ax | grep -- '-sname rabbit' | perl -nE 'for (/-A\s*\d+/g) { say } '
-A 64
-A18
Expected results:
Only one '-A' option for beam.smp, with value calculated according to chosen algorithm
Impact:
Machine with big number of CPU cores may be underutilized by rabbit
Changed in fuel: | |
assignee: | nobody → MOS Oslo (mos-oslo) |
tags: | added: area-mos |
Changed in fuel: | |
milestone: | none → 10.0 |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in fuel: | |
assignee: | MOS Oslo (mos-oslo) → Alexey Lebedeff (alebedev-a) |
status: | Confirmed → In Progress |
no longer affects: | fuel/newton |
tags: | added: on-verification |
Reviewed: https:/ /review. openstack. org/332234 /git.openstack. org/cgit/ openstack/ fuel-library/ commit/ ?id=0c16cbc9a72 3edfc7a9edd08fa ac8f5fc1b974bf
Committed: https:/
Submitter: Jenkins
Branch: master
commit 0c16cbc9a723edf c7a9edd08faac8f 5fc1b974bf
Author: Alexey Lebedeff <email address hidden>
Date: Tue Jun 21 18:58:51 2016 +0300
Remove erlang/rabbit thread pool calculation
Proper version of this calculation is implemented upstream - /github. com/rabbitmq/ rabbitmq- server/ issues/ 151
https:/
And removed version of the code is actually harmful, as it's using cessorcount (i.e. number of CPU sockets) for
physicalpro
calculations. So on a 2 CPU/48 thread system there it was 30 threads
instead of 768 calculated upstream.
I've decided that it's easier to completely remove this code instead
of duplicating current formula in upstream and providing a way to
override this value through hiera - just not worth a hassle.
Change-Id: I415d446af0a822 d2a5ce3478fd9db 1dd0f13e115
Closes-Bug: 1573696