[octane] Octane does not backup profiles and distros

Bug #1571586 reported by Roman Sokolkov on 2016-04-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
High
Sergey Abramov
7.0.x
High
Unassigned
8.0.x
High
Unassigned
Mitaka
High
Unassigned
Newton
High
Sergey Abramov

Bug Description

When upgrading Fuel master to 8.0, Octane backups only "systems" from cobbler.

But in case 6.X source version we have profile and distro for Ubuntu 12.04, which is not available in 8.0

I'm getting following traceback, while "cobber sync":
http://paste.openstack.org/show/494387/

Steps to reproduce:
1) (fuel 6.0) octane backup
2) (fuel 8.0) octane restore
3) cobbler sync

Expected result:
Successful cobbler sync

Actual result:
Fail

Workaround:
dockerctl copy distros.d/ubuntu_1204_x86_64.json cobbler:/var/lib/cobbler/config/distros.d
dockerctl copy profiles.d/ubuntu_1204_x86_64.json cobbler:/var/lib/cobbler/config/profiles.d

description: updated
Dmitry Klenov (dklenov) on 2016-04-18
tags: added: area-python
Changed in fuel:
milestone: none → 9.0
assignee: nobody → Fuel Octane (fuel-octane-team)
importance: Undecided → High
status: New → Confirmed
Dmitry Pyzhov (dpyzhov) on 2016-04-19
no longer affects: fuel/newton
Changed in fuel:
milestone: 9.0 → 10.0
Dmitry Klenov (dklenov) wrote :

The fix is needed starting from 8.0 according to discussion with Roman Sokolkov.

Oleg S. Gelbukh (gelbuhos) wrote :

I believe it is still needed for 7.0 since that version is used to create backup from 6.x version. Changing the status for 7.0.0 series.

Changed in fuel:
assignee: Fuel Octane (fuel-octane-team) → Sergey Abramov (sabramov)
status: Confirmed → In Progress

Reviewed: https://review.openstack.org/308267
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=0165988b8f5421c3bf2f0d56d13ea2827f0f7672
Submitter: Jenkins
Branch: master

commit 0165988b8f5421c3bf2f0d56d13ea2827f0f7672
Author: Sergey Abramov <email address hidden>
Date: Wed Apr 20 13:57:11 2016 +0300

    Add cobbler profiles and distros backup

    During the upgrade from the 6.0 release configuration files of profiles and
    distributions for Cobbler should be preserved because this release provides
    Ubuntu 12.04 that is not presented in 8.0.

    Closes-bug: 1571586
    Change-Id: Id9323cbd5f5b73451e5d97ffd4191155c5f5dd5f

Changed in fuel:
status: In Progress → Fix Committed

Reviewed: https://review.openstack.org/309900
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=307c67a63b355334e3bd7b2b17f9fc80298b6cad
Submitter: Jenkins
Branch: stable/8.0

commit 307c67a63b355334e3bd7b2b17f9fc80298b6cad
Author: Sergey Abramov <email address hidden>
Date: Wed Apr 20 13:57:11 2016 +0300

    Add cobbler profiles and distros backup

    During the upgrade from the 6.0 release configuration files of profiles and
    distributions for Cobbler should be preserved because this release provides
    Ubuntu 12.04 that is not presented in 8.0.

    Closes-bug: 1571586
    Change-Id: Id9323cbd5f5b73451e5d97ffd4191155c5f5dd5f
    (cherry picked from commit 0165988b8f5421c3bf2f0d56d13ea2827f0f7672)

Reviewed: https://review.openstack.org/309901
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=bfc286cc116463497a4f8bc3ba3dc808dfa0b742
Submitter: Jenkins
Branch: stable/7.0

commit bfc286cc116463497a4f8bc3ba3dc808dfa0b742
Author: Sergey Abramov <email address hidden>
Date: Wed Apr 20 13:57:11 2016 +0300

    Add cobbler profiles and distros backup

    During the upgrade from the 6.0 release configuration files of profiles and
    distributions for Cobbler should be preserved because this release provides
    Ubuntu 12.04 that is not presented in 8.0.

    Closes-bug: 1571586
    Change-Id: Id9323cbd5f5b73451e5d97ffd4191155c5f5dd5f
    (cherry picked from commit 0165988b8f5421c3bf2f0d56d13ea2827f0f7672)

Pavel Chechetin (paulche) wrote :

I've just checked proposed patch and can confirm it works.

tags: added: dev-to-verify
tags: removed: dev-to-verify
Download full text (40.5 KiB)

Reviewed: https://review.openstack.org/332931
Committed: https://git.openstack.org/cgit/openstack/fuel-octane/commit/?id=24f3c396612eb0c69fbf06bab3cebbb9ca829426
Submitter: Jenkins
Branch: stable/mitaka

commit b34d749f1c281dafbdbf155bd86830dc8f2a9aa2
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 21:10:56 2016 +0300

    Support mock==1.8.0 in unit tests

    Use assert_called_once_with instead of assert_called_once that was
    introduced in 2.0.0.

    Change-Id: Ifb7699d4b552d148984961727355f0e23b487c7c

commit d60f1905143bb7576ffd670595de1c4aeafd7b34
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 02:01:52 2016 +0300

    Allow to authorize by the predefined admin_token

    The admin_token_auth middleware is added to keystone pipelines to
    allow authorization by admin_token.

    Change-Id: Ic03150305a669fad1446436a68051fb9aa25b892

commit cc7fab59f44ffef60285f8732d798f52469b2530
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:47:01 2016 +0300

    Reset default_domain_id before the keystone task

    The default_domain_id should be removed from keystone.conf after restore
    of DB and before to apply the keystone puppet task to avoid of using the
    configured domain as a default.

    Change-Id: I05a6c48532e8042496b3d8ccef53d65bf8c44653

commit e3f82399d567dbcfc1ae9a1ecbddba7bf5028fc8
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:32:47 2016 +0300

    Add helper function to iterate over parameters

    The helpers.iterate_parameters function allows to iterate over lines of
    INI-like files along with a context of information, such section,
    parameter and value.

    Change-Id: I55b179118116fd5dacf100754057ea6589782dc2

commit 5ed370a4fbb3369d0f75873d205ac7f0c655f93a
Author: Ilya Kharin <email address hidden>
Date: Wed Jun 22 01:18:05 2016 +0300

    Add update_file context manager for local files

    The subprocess.update_file function provides an ability to update
    content of a local file by iterating over lines of an original file and
    forming a result content in a temporary file to replace the original
    file in the end. This function is very useful to change configuration
    files.

    Change-Id: I433a5da67887b231400dd63131799019f45c277c

commit 58f31e6c5f408630c42565ee53de6b59457bc84c
Author: Oleg Gelbukh <email address hidden>
Date: Wed Jun 22 14:34:03 2016 +0000

    Escape passwords passed to openstack client

    If special symbols are used in password for 'admin' user in
    OpenStack, octane passes them to command line client as is
    and it breaks shell.

    Properly escape the password before passing it to subprocess.

    Change-Id: Iad635aec6d5b5cc32975937e00205b7e89dc99d9
    Closes-bug: 1585960

commit 896aba1191eeb59cf85cc8be6a2ae67e08b76070
Author: Yuriy Taraday <email address hidden>
Date: Wed Jun 22 15:28:45 2016 +0300

    Add absolute_import to util/docker.py to avoid local tempfile module

    Closes-Bug: 1595156
    Change-Id: I9484efce6fa7aec1b41cf592f9e9768d85931fa7

commit 46586a62df962b2ce00b5d8a63f6fd34c920a1f4
Author: Oleg Gelbukh <email address hidden>
Date: Thu M...

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers