fix fuel-library unit tests

[Aleksandra Fedorova]

Due to request https://bugs.launchpad.net/bugs/1455817 unit tests for fuel-library repo were switched to non-voting mode for 6.1

We need to fix them and enable in 7.0

[Aleksandr Didenko (adidenko)]

Partial fix https://review.openstack.org/#/c/195625/

[Aleksandr Didenko (adidenko)]

We also need to fix unit tests for l23network and then we can enable them back into voting mode. Errors in l23network are:

Failures:

  1) function_get_network_role_property mtk should return NIL for "admin" network role
     Failure/Error: should run.with_params('admin', 'phys_dev').and_return(nil)
       expected get_network_role_property("admin", "phys_dev") to have returned nil instead of ["eth0"]
     # ./spec/functions/get_network_role_property__spec.rb:90:in `block (3 levels) in <top (required)>'

  2) function_get_transformation_property get_transformation_property('some_property', 'transformation') usage should return NIL for "eth2" transformation
     Failure/Error: should run.with_params('mtu', 'eth2').and_return(nil)
       expected get_transformation_property("mtu", "eth2") to have returned nil instead of 1024
     # ./spec/functions/get_transformation_property__spec.rb:120:in `block (3 levels) in <top (required)>'

[Stanislav Makar (smakar)]

this happens due to new version of rspec-puppet 2.2.0
with rspec-puppet 2.1.0 and 2.0.1 all is ok

[Stanislav Makar (smakar)]

Fixes the patch https://review.openstack.org/#/c/197041/

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: master
Change author: Alexander Didenko <email address hidden>
Review: https://review.fuel-infra.org/9028

[Aleksandr Didenko (adidenko)]

Fixes merged, need to switch the job to voting mode:
https://review.fuel-infra.org/9028

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/6.1
Review: https://review.openstack.org/219186

[Sergey Vilgelm (sergey.vilgelm)]

This bug is still in progress. The main problem is fixed but the job is not voting yet.

[Aleksandr Didenko (adidenko)]

Fix is on review since sept 1, please merge it:
https://review.openstack.org/#/c/219186/

Forwarding to maintenance team.

[Aleksandr Didenko (adidenko)]

Clarification:
https://review.openstack.org/#/c/219186/ fixes unti tests for 6.1, after that we can switch jobs to voting mode for all branches
https://review.fuel-infra.org/#/c/9028/ switches unit test jobs to voting mode

[Vitaly Sedelnik (vsedelnik)]

The reviews above have no CR+2

[Denis Meltsaykin (dmeltsaykin)]

This bugreport is regarding 6.1, other milestones here are Invalid.

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Alexander Didenko <email address hidden> on branch: master
Review: https://review.fuel-infra.org/9028
Reason: Outdated

[OpenStack Infra (hudson-openstack)]

Change abandoned by Aleksandr Didenko (<email address hidden>) on branch: stable/6.1
Review: https://review.openstack.org/219186
Reason: It looks like it's no longer needed.