Puppet failed with error: Duplicate declaration: File[/etc/init/cinder-volume.override

[Nastya Urlapova]

{
    "build_id": "2015-02-16_22-54-44",
    "ostf_sha": "f9c37d0876141e1550eb4e703a8e500cd463282f",
    "build_number": "128",
    "release_versions": {
        "2014.2-6.1": {
            "VERSION": {
                "build_id": "2015-02-16_22-54-44",
                "ostf_sha": "f9c37d0876141e1550eb4e703a8e500cd463282f",
                "build_number": "128",
                "api": "1.0",
                "nailgun_sha": "3b5a6fdb7254d25a3b7000405f70e242bca200eb",
                "production": "docker",
                "python-fuelclient_sha": "33ce5fb5e483b91b1448ba57aa705df4d052f066",
                "astute_sha": "8af8e88c3cb17b66368e7a038f1899e5c7c13e98",
                "feature_groups": [
                    "mirantis"
                ],
                "release": "6.1",
                "fuelmain_sha": "2054229e275d08898b5d079a6625ffcc79ae23b8",
                "fuellib_sha": "c74044e8397d6b3019b4794e2c3bb30754b8bc71"
            }
        }
    },
    "auth_required": true,
    "api": "1.0",
    "nailgun_sha": "3b5a6fdb7254d25a3b7000405f70e242bca200eb",
    "production": "docker",
    "python-fuelclient_sha": "33ce5fb5e483b91b1448ba57aa705df4d052f066",
    "astute_sha": "8af8e88c3cb17b66368e7a038f1899e5c7c13e98",
    "feature_groups": [
        "mirantis"
    ],
    "release": "6.1",
    "fuelmain_sha": "2054229e275d08898b5d079a6625ffcc79ae23b8",
    "fuellib_sha": "c74044e8397d6b3019b4794e2c3bb30754b8bc71"
}

Scanario:
Case: ha_neutron_ceph
1. Create cluster
2. Add 3 nodes with controller and ceph OSD roles
3. Add 1 node with ceph OSD roles
4. Add 2 nodes with compute and ceph OSD roles
5. Deploy the cluster
6. Check ceph status

Deployment failed on first controller with error:

2015-02-17 00:26:43 ERR
 /usr/bin/puppet:4
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:91:in `execute'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/util/command_line.rb:137:in `run'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `run'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/util.rb:478:in `exit_on_fail'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `run'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/application.rb:470:in `plugin_hook'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/application.rb:364:in `run'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:146:in `run_command'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/application/apply.rb:207:in `main'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:399:in `to_ral'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:497:in `to_catalog'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:497:in `each'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:513:in `to_catalog'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:68:in `add_resource'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:68:in `each'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:69:in `add_resource'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:81:in `add_one_resource'
2015-02-17 00:26:43 ERR
 /usr/lib/ruby/vendor_ruby/puppet/resource/catalog.rb:484:in `fail_on_duplicate_type_and_title'
2015-02-17 00:26:43 ERR
 Duplicate declaration: File[/etc/init/cinder-volume.override] is already declared in file /etc/puppet/modules/tweaks/manifests/ubuntu_service_override.pp:17; cannot redeclare

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/156533

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/156533
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=abc0c4aa0a70338cbfba64267a2b784e4e3a6dd6
Submitter: Jenkins
Branch: master

commit abc0c4aa0a70338cbfba64267a2b784e4e3a6dd6
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Feb 17 11:16:45 2015 +0100

    Override cinder-volume service only for Cinder role

    W/o this fix, tweaks::ubuntu_service_override { 'cinder-volume' }
    is called for controller and compute roles as well as for cinder role
    and that causes the double declaration conflict.
    The solution is to invoke this override only for cinder role.

    Change-Id: I3b49968bb1c38d55cece507e0e7f5b950f890c1f
    Closes-bug: #1422579
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/158272

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: stable/6.0
Review: https://review.openstack.org/158272
Reason: superseded by https://review.openstack.org/#/c/156257/

[Bogdan Dobrelya (bogdando)]

The 6.0 backport was addressed by https://review.openstack.org/#/c/156257/

[Anastasia Palkina (apalkina)]

Verified on ISO #165

"build_id": "2015-03-05_22-54-44", "ostf_sha": "8df5f2fcdae3bc9ea7d700ffd64db820baf51914", "build_number": "165", "release_versions": {"2014.2-6.1": {"VERSION": {"build_id": "2015-03-05_22-54-44", "ostf_sha": "8df5f2fcdae3bc9ea7d700ffd64db820baf51914", "build_number": "165", "api": "1.0", "nailgun_sha": "f12221d79e0d97c7b4405331e11a54fc5dcfcd4e", "production": "docker", "python-fuelclient_sha": "4eb787f1ad969bd23c93d192865543dbd45a8626", "astute_sha": "ca7635a356a90404d3dedb5cf26f1d16e07144a9", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "0e45b31db1677651d6ddb1c852d62ebfd8875dcd", "fuellib_sha": "07288d7bfde840b7ec47292ff96a3b670a79c859"}}}, "auth_required": true, "api": "1.0", "nailgun_sha": "f12221d79e0d97c7b4405331e11a54fc5dcfcd4e", "production": "docker", "python-fuelclient_sha": "4eb787f1ad969bd23c93d192865543dbd45a8626", "astute_sha": "ca7635a356a90404d3dedb5cf26f1d16e07144a9", "feature_groups": ["mirantis"], "release": "6.1", "fuelmain_sha": "0e45b31db1677651d6ddb1c852d62ebfd8875dcd", "fuellib_sha": "07288d7bfde840b7ec47292ff96a3b670a79c859"

Ubuntu, Ceph for volumes and Ceph for images
3 controller+ceph, 2 compute+ceph, 1 ceph