nailgun should send puppet_modules_source with version

[Matthew Mosesohn]

This blocks https://bugs.launchpad.net/fuel/+bug/1382531

Nailgun should tell astute during deployment to use the path rsync://$MASTER_IP:/puppet/$RELEASE/modules (and for manifests, respectively).

Symbolic links can be broken because of the way host manifests are mounted within a docker conatiner.

[Evgeniy L (rustyrobot)]

Could you please provide clear steps to reproduce, expected result, actual result? It's not clear what happens and why it affects 5.1.1.

[Matthew Mosesohn (raytrac3r)]

Ignore 5.1.1. It affects 6.0 and let me explain why.

Here is the situation:
6.0 sets up puppet in /etc/puppet/2014.2-6.0/{modules,manifests} then symlinks the path. Nailgun only sends rsync://$MASTER:/puppet/modules as the path. This is misleading because the Puppet path relies now on a symlinked path. It should be the full version. What if we upgrade from 5.1 to 6.0? Will Nailgun send the fully qualified path or just send 5.1 manifests when deploying 6.0?

To me it seems that the puppet path should be explicit for the rsync command and not rely on weak symlinks that are _not_ managed by fuel_upgrade.

[Matthew Mosesohn (raytrac3r)]

Back to fuel-python again

[Ihor Kalnytskyi (ikalnytskyi)]

@Mat, I'll take a look.

But I want you to know 2 things before:

> Nailgun only sends rsync://$MASTER:/puppet/modules

I'm not sure about this, but if you right - we need to fix that, no doubts. But it's not critical and don't block anything. Why? Read explanations below.

> What if we upgrade from 5.1 to 6.0?

When you upgrade from 5.1 to 6.0 the situation is different. During upgrade step we explicitly set the full paths to modules/manifests, so Nailgun will send you rsync://$MASTER:/puppet/$OPENSTACK_VERSION/modules

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/136836

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/136836
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=a1c1d3f2f9841e3384108e201cd2a907c0c2f9c6
Submitter: Jenkins
Branch: master

commit a1c1d3f2f9841e3384108e201cd2a907c0c2f9c6
Author: Igor Kalnitsky <email address hidden>
Date: Mon Nov 24 15:15:09 2014 +0200

    Always send versioned paths to manifests/repos

    Since Fuel 6.0 we always have versioned folders for puppet manifests and
    repos, so there no need to send unversioned paths by default. The patch
    implements it by adding records to release_orchestrator_data for initial
    releases.

    Change-Id: Icb7c4449696e4032e6d8e1e939ae621614e2bc18
    Closes-Bug: #1395047