[library] Ceph-deploy OSD prepare fails on HP Smart Array CCISS drives

[Miroslav Anashkin]

ceph-deploy osd prepare command fails on HP Smart Array CCISS drives.
These drives are visible in Linux as /dev/CCISS/cXdXpX or as cciss!c0d0 - in other words has non-standard SCSI names and actually are not part of SCSI stack.
Additional separators in disk drive names make ceph-deploy unable to create xfs partition properly.
Also, there is no proper errors in Puppet logs on this issue.

From customer:
MOS 5.1
I use the following setup:
1 Controller,
3x ceph-osd + compute

expected result: ceph osds are initialized and added to the ceph pool.
actual result: no OSD added to the ceph pool, installation fails when trying to upload images

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/128450

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/128739

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/128450
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=bc61411d5d1fba2758df08c5008bc0242433815c
Submitter: Jenkins
Branch: master

commit bc61411d5d1fba2758df08c5008bc0242433815c
Author: Andrew Woodward <email address hidden>
Date: Tue Oct 14 14:37:28 2014 -0700

    Add support for cciss p seperator in ceph-osd fact

    the facter code was subsituting the ! in the cciss device, but had forgotten
     about the p seperator between the device and partation number.

    the patch adds the p seperator if the ! is matched in the gsub to the remaining
     locations that would need the p seperator to properly refrence devices.

    Change-Id: I5054cde345495b62fa66f3ae3876fc6eb098cc5c
    Closes-bug: 1381218

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/128739
Committed: https://git.openstack.org/cgit/stackforge/fuel-library/commit/?id=f18db6ac586491f4afc4b460c5aee9ff407dad73
Submitter: Jenkins
Branch: stable/5.1

commit f18db6ac586491f4afc4b460c5aee9ff407dad73
Author: Andrew Woodward <email address hidden>
Date: Tue Oct 14 14:37:28 2014 -0700

    Add support for cciss p seperator in ceph-osd fact

    the facter code was subsituting the ! in the cciss device, but had forgotten
     about the p seperator between the device and partation number.

    the patch adds the p seperator if the ! is matched in the gsub to the remaining
     locations that would need the p seperator to properly refrence devices.

    Change-Id: I5054cde345495b62fa66f3ae3876fc6eb098cc5c
    Closes-bug: 1381218